Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chrome] Extension to append an element to the last breadcrumb #82015

Merged
merged 3 commits into from
Oct 30, 2020
Merged

[Chrome] Extension to append an element to the last breadcrumb #82015

merged 3 commits into from
Oct 30, 2020

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Oct 29, 2020

Summary

New extension point for chrome that allows to append an element to the last breadcrumb.

Needed for future send to background UI: #81004
Mocks https://whimsical.com/LMKSnR7vmPrmAypPXYuA8T
In this end will look something like this:
image

This pr adds and extension point, but no-one actually uses it, so no way to play with it from the UI.
If you want to play, then try: #81793

Implementation notes

Q: Why not just append an element to the last breadcrumb using existing breadcrumb API?

A: We don't want apps to use this API, instead this "Send to background UI" will be added by data_enhanced plugin (see pr). This indicator will be rendered when a page is using background sessions.
No additional setup from apps is needed. This approach also allows to keep "Send to background UI" in x-pack.

Checklist

Delete any items that are not applicable to this PR.

@Dosant Dosant added Feature:Search Querying infrastructure in Kibana v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 29, 2020
@Dosant Dosant marked this pull request as ready for review October 29, 2020 16:20
@Dosant Dosant requested a review from a team as a code owner October 29, 2020 16:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

pgayvallet
pgayvallet approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think at some point we might need a breadcrumbWrapper pattern to allow plugins to adapt or transform the breadcrumb in a more generic way.

This will be good enough for now. Could you please make sure to add a FTR test for the feature using this new API to be sure we don't break anything when we'll add this wrapper pattern?

@Dosant
Copy link
Contributor Author

Dosant commented Oct 30, 2020 •
edited
Loading

I think at some point we might need a breadcrumbWrapper pattern to allow plugins to adapt or transform the breadcrumb in a more generic way.

That's true. Didn't want to overcomplicate until more use cases are known.

Could you please make sure to add a FTR test for the feature using this new API to be sure we don't break anything when we'll add this wrapper pattern?

Yes, of course!

@Dosant
Copy link
Contributor Author

Dosant commented Oct 30, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
core 543.4KB 544.6KB +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit f5b1fae into elastic:master Oct 30, 2020
Dosant added a commit to Dosant/kibana that referenced this pull request Oct 30, 2020
@Dosant
[Chrome] Extension to append an element to the last breadcrumb (elast…
9e81d37 
…ic#82015)
@Dosant Dosant mentioned this pull request Oct 30, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 30, 2020
@gmmorris
Merge branch 'master' into alerts/convert-to-tm-intervals
1929b5d 
* master: (71 commits)
  [Chrome] Extension to append an element to the last breadcrumb (elastic#82015)
  [Monitoring] Thread pool rejections alert (elastic#79433)
  [Actions] Fix actionType type on registerType function (elastic#82125)
  [Security Solution] Modal for saving timeline (elastic#81802)
  add tests for index pattern switching (elastic#81987)
  TS project references for share plugin (elastic#82051)
  [Graph] Fix problem with duplicate ids (elastic#82109)
  skip 'returns a single bucket if array has 1'.  related elastic#81460
  Add a link to documentation in the alerts and actions management UI (elastic#81909)
  [Fleet] fix duplicate ingest pipeline refs (elastic#82078)
  Context menu trigger for URL Drilldown (elastic#81158)
  SO management: fix legacy import index pattern selection being reset when switching page (elastic#81621)
  Fixed dead links (elastic#78696)
  [Search] Add "restore" to session service (elastic#81924)
  fix Lens heading structure (elastic#81752)
  [ML] Data Frame Analytics: Fix feature importance cell value and decision path chart (elastic#82011)
  Remove legacy app arch items from codeowners. (elastic#82084)
  [TSVB] Renamed 'positive rate' to 'counter rate' (elastic#80939)
  Expressions/migrations2 (elastic#81281)
  [Telemetry] [Schema] remove number type and support all es number types (elastic#81774)
  ...
Dosant added a commit that referenced this pull request Oct 30, 2020
@Dosant
[Chrome] Extension to append an element to the last breadcrumb (#82015)…
82db4ef 
… (#82142)
@Dosant Dosant mentioned this pull request Nov 9, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dosant @elasticmachine @kibanamachine @pgayvallet