[ftr/menuToggle] provide helper for enhanced menu toggle handling #81709
+140
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
v8.0.0
release_note:skip
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
nreese
approved these changes
Oct 27, 2020
dmlemeshko
approved these changes
Oct 27, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 27, 2020
…astic#81709) Co-authored-by: spalger <spalger@users.noreply.github.com> # Conflicts: # test/functional/services/common/test_subjects.ts
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 27, 2020
…astic#81709) Co-authored-by: spalger <spalger@users.noreply.github.com> # Conflicts: # test/functional/services/common/test_subjects.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 27, 2020
* master: (87 commits) [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81778) [i18n] add get_kibana_translation_paths tests (elastic#81624) [UX] Fix search term reset from url (elastic#81654) [Lens] Improved range formatter (elastic#80132) [Resolver] `SideEffectContext` changes, remove `@testing-library` uses (elastic#81077) [Time to Visualize] Update Library Text with Call to Action (elastic#81667) [docs] Resolving failed Kibana upgrade migrations (elastic#80999) [ftr/menuToggle] provide helper for enhanced menu toggle handling (elastic#81709) [Task Manager] adds basic observability into Task Manager's runtime operations (elastic#77868) Doc changes for stack management and grouped feature privileges (elastic#80486) Added functional test for alerts list filters by status, alert type and action type. Did a code refactoring and splitting for alerts tests. (elastic#81422) [Security Solution][Endpoint][Admin] Malware Protections Notify User Version (elastic#81415) Revert "[Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390)" [Maps] Use default format when proxying EMS-files (elastic#79760) [Discover] Deangularize context.html (elastic#81442) Use the displayName property in default editor (elastic#73311) adds bug label to Bug report for Security Solution template (elastic#81643) [ML] Transforms: Remove index field limitation for custom query. (elastic#81467) [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390) [Task Manager] Mark task as failed if maxAttempts has been met. (elastic#80681) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #81698
When adding a new set of functional tests that execute along with the normal CI groups some of the logic used to manage menu state started to fail because the timing was adjusted somewhat. I took a look and think the
MenuTogglehelper handled opening/closing menus by clicking a toggle button a little better than it is done today without making things much slower.I had originally implemented this in the
gisPageObject but then once those tests started passing I noticed very similar logic in thetimePickerPageObject failing as well. To make sure the fix was applied equally to both PageObjects I added aMenuToggleservice which provides a class that can be instantiated to provide.open()and.close()functions for a specific menu which can be reused within a service.@nreese it looks like you've worked on a lot of this code so if you wouldn't mind taking a look at the changes I'd appreciate it.