-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add experimental copy to upgrade agent(s) #81410
[Fleet] Add experimental copy to upgrade agent(s) #81410
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
@gchaps Could you review the copy changes here? |
Tooltip This is our standard language: The upgrade agent might change or be removed in a future release and is not subject to the support SLA. Modal Upgrade agent? This action upgrades the agent running on 'Jens-MacBook-Pro.local' to version 8.0.0. You can't undo this upgrade. Cancel | Upgrade agent Note: I removed the "experimental" text in the body of the modal because I think the Experiemental label and tooltip cover that information. I'd be happy to review again if you post an updated image. |
Thanks @gchaps. Updated copy & screenshot. |
@@ -106,7 +132,7 @@ export const AgentUpgradeAgentModal: React.FunctionComponent<Props> = ({ | |||
{isSingleAgent ? ( | |||
<FormattedMessage | |||
id="xpack.ingestManager.upgradeAgents.upgradeSingleDescription" | |||
defaultMessage='This action will upgrade the selected agent running on "{hostName}" to version {version}. This action cannot be undone. Are you sure you wish to continue?' | |||
defaultMessage='This action upgrades the agent running on "{hostName}" to version {version}. You can't undo this upgrade.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't ideal but using a template literal throws an error during i18n check (#81862) and escaping the single quote doesn't work either
Minor comment. Use single quotes instead of double quotes in the message body. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
* Add experimental copy to upgrade agent(s) * Adjust copy after review * Fix string * Adjust quotes # Conflicts: # x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/fleet/components/agent_upgrade_modal/index.tsx
* Add experimental copy to upgrade agent(s) * Adjust copy after review * Fix string * Adjust quotes # Conflicts: # x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/fleet/components/agent_upgrade_modal/index.tsx
Summary
Resolves #81337. This PR adds experimental messaging to the upgrade agent(s) feature.