Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add experimental copy to upgrade agent(s) #81410

Merged
merged 6 commits into from
Oct 29, 2020

Conversation

jen-huang
Copy link
Contributor

@jen-huang jen-huang commented Oct 21, 2020

Summary

Resolves #81337. This PR adds experimental messaging to the upgrade agent(s) feature.

image

@jen-huang jen-huang added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 labels Oct 21, 2020
@jen-huang jen-huang requested a review from a team October 21, 2020 22:41
@jen-huang jen-huang self-assigned this Oct 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jen-huang jen-huang requested a review from gchaps October 21, 2020 22:42
@jen-huang
Copy link
Contributor Author

@gchaps Could you review the copy changes here?

@gchaps
Copy link
Contributor

gchaps commented Oct 26, 2020

Tooltip

This is our standard language:

The upgrade agent might change or be removed in a future release and is not subject to the support SLA.

Modal

Upgrade agent?

This action upgrades the agent running on 'Jens-MacBook-Pro.local' to version 8.0.0. You can't undo this upgrade.

Cancel | Upgrade agent

Note: I removed the "experimental" text in the body of the modal because I think the Experiemental label and tooltip cover that information. I'd be happy to review again if you post an updated image.

@jen-huang
Copy link
Contributor Author

Thanks @gchaps. Updated copy & screenshot.

@@ -106,7 +132,7 @@ export const AgentUpgradeAgentModal: React.FunctionComponent<Props> = ({
{isSingleAgent ? (
<FormattedMessage
id="xpack.ingestManager.upgradeAgents.upgradeSingleDescription"
defaultMessage='This action will upgrade the selected agent running on "{hostName}" to version {version}. This action cannot be undone. Are you sure you wish to continue?'
defaultMessage='This action upgrades the agent running on "{hostName}" to version {version}. You can&#39;t undo this upgrade.'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't ideal but using a template literal throws an error during i18n check (#81862) and escaping the single quote doesn't work either

@gchaps
Copy link
Contributor

gchaps commented Oct 27, 2020

Minor comment. Use single quotes instead of double quotes in the message body.

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
ingestManager 1.2MB 1.2MB +895.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jen-huang jen-huang merged commit 0094f7e into elastic:master Oct 29, 2020
@jen-huang jen-huang deleted the ingest/upgrade-experimental branch October 29, 2020 20:26
jen-huang added a commit to jen-huang/kibana that referenced this pull request Oct 29, 2020
* Add experimental copy to upgrade agent(s)

* Adjust copy after review

* Fix string

* Adjust quotes
# Conflicts:
#	x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/fleet/components/agent_upgrade_modal/index.tsx
jen-huang added a commit that referenced this pull request Oct 30, 2020
* Add experimental copy to upgrade agent(s)

* Adjust copy after review

* Fix string

* Adjust quotes
jen-huang added a commit that referenced this pull request Oct 30, 2020
* Add experimental copy to upgrade agent(s)

* Adjust copy after review

* Fix string

* Adjust quotes
# Conflicts:
#	x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/fleet/components/agent_upgrade_modal/index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ingest Manager] Add text to mark agent binary upgrade as experimental
5 participants