-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kbn/bootstrap] validate that certain deps don't ship in production #80549
[kbn/bootstrap] validate that certain deps don't ship in production #80549
Conversation
💚 Build SucceededMetrics [docs]distributable file count
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-operations (Team:Operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
telemetry-tools changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…lastic#80549) Co-authored-by: spalger <spalger@users.noreply.github.com> # Conflicts: # packages/kbn-pm/dist/index.js
…lastic#80549) Co-authored-by: spalger <spalger@users.noreply.github.com> # Conflicts: # packages/kbn-pm/dist/index.js # packages/kbn-pm/src/commands/bootstrap.ts
@restrry discovered in #80463 that we're shipping
@kbn/dev-utils
in production, so I figured it was time to start validating that certain packages stay dev only.This adds a check to
yarn kbn bootstrap
to look for packages in the tree of production dependencies forkibana
andx-pack
which are flagged with a newkibana.devOnly
property (in their package.json).To start I've labeled the following packages as dev only:
@elastic/eslint-config-kibana
@kbn/babel-preset
@kbn/dev-utils
@kbn/es
@kbn/es-archiver
@kbn/eslint-import-resolver-kibana
@kbn/eslint-plugin-eslint
@kbn/expect
@kbn/pm
@kbn/release-notes
@kbn/storybook
@kbn/telemetry-tools
@kbn/test
@kbn/test-subj-selector
@kbn/utility-types
When these packages make their way into the production dependency chain we print out an error that includes a map to help people understand where the issue is and help them fix it: