Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Telemetry Management Section] Lazy-load security payload #79854

Merged
merged 3 commits into from
Nov 2, 2020
Merged

[Telemetry Management Section] Lazy-load security payload #79854

merged 3 commits into from
Nov 2, 2020

Conversation

afharo
Copy link
Member

@afharo afharo commented Oct 7, 2020 •
edited
Loading

Summary

After we merged #78963, the bundle size got increased because of the static JSON payload in the new security fly-out. This PR moves it to a lazy component. This way it can grow as much as we need, without affecting the Advanced Settings loading speed.

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@afharo afharo marked this pull request as ready for review October 7, 2020 20:38
@afharo afharo requested a review from a team as a code owner October 7, 2020 20:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@afharo afharo marked this pull request as draft October 7, 2020 20:39
@afharo
Copy link
Member Author

afharo commented Oct 7, 2020

Converting it back to draft because #79859 might change things a bit

Bamieh
Bamieh approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@afharo
Copy link
Member Author

afharo commented Nov 2, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
telemetryManagementSection 9 11 +2

async chunk count

id before after diff
telemetryManagementSection 0 1 +1

async chunks size

id before after diff
telemetryManagementSection 0.0B 2.8KB +2.8KB

distributable file count

id before after diff
default 48128 48131 +3
oss 28590 28593 +3

page load bundle size

id before after diff
telemetryManagementSection 27.6KB 26.1KB -1.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo marked this pull request as ready for review November 2, 2020 17:06
@afharo afharo merged commit 5bf1a36 into elastic:master Nov 2, 2020
@afharo afharo deleted the telemetryManagementSection/lazySecurityExamplePayload branch November 2, 2020 17:10
@afharo afharo mentioned this pull request Nov 2, 2020
Merged
afharo added a commit that referenced this pull request Nov 3, 2020
@afharo @kibanamachine
[7.x] [Telemetry Management Section] Lazy-load security payload (#79854…
943d9ca 
…) (#82323)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bamieh Bamieh Bamieh approved these changes

Assignees
No one assigned
Labels
Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@afharo @elasticmachine @kibanamachine @Bamieh @lukeelmers