[Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… #79291

nchaulet · 2020-10-02T13:25:45Z

Description

In our effort to rename the Ingest Manager plugin Fleet, we are doing a few renaming through the whole plugin.
The Fleet tab is now the Agents tab, and to setup that tab we are now talking about enabling Central management for Elastic Agent instead of Fleet

UI Change

How to tests

If you want to see the setup page just start with a fresh elastic search
if you want to see the restrictions page you can run ES without api keys enabled yarn es snapshot --license trial --password changeme

elasticmachine · 2020-10-02T13:25:47Z

Pinging @elastic/ingest-management (Team:Ingest Management)

… management for Elastic Agents

...lugins/ingest_manager/public/applications/ingest_manager/sections/fleet/setup_page/index.tsx

…er/sections/fleet/setup_page/index.tsx Co-authored-by: Jen Huang <its.jenetic@gmail.com>

dedemorton

A couple of minor edits. If it's clear that you're talking about managing agents, IMO it's OK to say "central management" without qualifying it.

dedemorton · 2020-10-02T20:15:25Z

...lugins/ingest_manager/public/applications/ingest_manager/sections/fleet/setup_page/index.tsx

                />
              </h2>
            </EuiTitle>
            <EuiSpacer size="xl" />
            <EuiText color="subdued">
              <FormattedMessage
                id="xpack.ingestManager.setupPage.enableText"
-                defaultMessage="Fleet requires an Elastic user who can create API keys and write to logs-* and metrics-*."
+                defaultMessage="Central management for Elastic Agents requires an Elastic user who can create API keys and write to logs-* and metrics-*."


You don't need to repeat "Elastic Agents" here since it's established in the title.

...lugins/ingest_manager/public/applications/ingest_manager/sections/fleet/setup_page/index.tsx

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

kibanamachine · 2020-10-02T23:04:57Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: ca18b83
Flaky suites:
- xpack-kibana-ciGroup9

Test Failures

X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/spaces_only/tests/alerting/execution_status·ts.alerting api integration spaces only Alerting executionStatus should eventually be "ok" for no-op alert

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/79249

[00:00:00]       │
[00:00:00]         │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xxl-1601672903881304165] [.kibana-event-log-8.0.0-000001] creating index, cause [api], templates [.kibana-event-log-8.0.0-template], shards [1]/[1]
[00:00:00]         │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xxl-1601672903881304165] updating number_of_replicas to [0] for indices [.kibana-event-log-8.0.0-000001]
[00:00:00]         └-: alerting api integration spaces only
[00:00:00]           └-> "before all" hook
[00:00:38]           └-: Alerting
[00:00:38]             └-> "before all" hook
[00:00:38]             └-> "before all" hook
[00:00:38]               │ debg creating space
[00:00:38]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xxl-1601672903881304165] [.kibana_2/HbaUib01QJ2PlCVpmGsVrQ] update_mapping [_doc]
[00:00:39]               │ debg created space
[00:00:39]               │ debg creating space
[00:00:40]               │ debg created space
[00:02:24]             └-: executionStatus
[00:02:24]               └-> "before all" hook
[00:02:24]               └-> should be "pending" for newly created alert
[00:02:24]                 └-> "before each" hook: global before each
[00:02:25]                 └- ✓ pass  (1.7s) "alerting api integration spaces only Alerting executionStatus should be "pending" for newly created alert"
[00:02:25]               └-> should eventually be "ok" for no-op alert
[00:02:25]                 └-> "before each" hook: global before each
[00:02:27]                 │ proc [kibana]   log   [22:11:25.124] [info][eventLog][plugins] event logged: {"event":{"provider":"alerting","action":"execute","start":"2020-10-02T22:11:25.123Z","end":"2020-10-02T22:11:25.123Z","duration":0,"outcome":"success"},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"84336c56-506f-4538-8308-98a8183897fd","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert executed: test.noop:84336c56-506f-4538-8308-98a8183897fd: 'abc'","@timestamp":"2020-10-02T22:11:25.123Z","ecs":{"version":"1.5.0"}}
[00:02:27]                 │ proc [kibana]   log   [22:11:25.131] [info][eventLog][plugins] event logged: {"event":{"provider":"alerting","action":"execute","start":"2020-10-02T22:11:25.130Z","end":"2020-10-02T22:11:25.130Z","duration":0,"outcome":"success"},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"31b30702-28ec-4fb2-a465-7eb206fb9afe","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert executed: test.noop:31b30702-28ec-4fb2-a465-7eb206fb9afe: 'abc'","@timestamp":"2020-10-02T22:11:25.130Z","ecs":{"version":"1.5.0"}}
[00:02:27]                 └- ✖ fail: alerting api integration spaces only Alerting executionStatus should eventually be "ok" for no-op alert
[00:02:27]                 │       Error: expected [ '2020-10-02T22:11:23.167Z',
[00:02:27]                 │   '2020-10-02T22:11:23.173Z',
[00:02:27]                 │   '2020-10-02T22:11:25.185Z',
[00:02:27]                 │   '2020-10-02T22:11:25.124Z',
[00:02:27]                 │   '2020-10-02T22:11:25.196Z' ] to sort of equal [ '2020-10-02T22:11:23.167Z',
[00:02:27]                 │   '2020-10-02T22:11:23.173Z',
[00:02:27]                 │   '2020-10-02T22:11:25.124Z',
[00:02:27]                 │   '2020-10-02T22:11:25.185Z',
[00:02:27]                 │   '2020-10-02T22:11:25.196Z' ]
[00:02:27]                 │       + expected - actual
[00:02:27]                 │ 
[00:02:27]                 │        [
[00:02:27]                 │          "2020-10-02T22:11:23.167Z"
[00:02:27]                 │          "2020-10-02T22:11:23.173Z"
[00:02:27]                 │       +  "2020-10-02T22:11:25.124Z"
[00:02:27]                 │          "2020-10-02T22:11:25.185Z"
[00:02:27]                 │       -  "2020-10-02T22:11:25.124Z"
[00:02:27]                 │          "2020-10-02T22:11:25.196Z"
[00:02:27]                 │        ]
[00:02:27]                 │       
[00:02:27]                 │       at Assertion.assert (/dev/shm/workspace/parallel/2/kibana/packages/kbn-expect/expect.js:100:11)
[00:02:27]                 │       at Assertion.eql (/dev/shm/workspace/parallel/2/kibana/packages/kbn-expect/expect.js:244:8)
[00:02:27]                 │       at ensureDatetimesAreOrdered (test/alerting_api_integration/common/lib/test_assertions.ts:22:26)
[00:02:27]                 │       at Context.it (test/alerting_api_integration/spaces_only/tests/alerting/execution_status.ts:73:7)
[00:02:27]                 │ 
[00:02:27]                 │

Stack Trace

{ Error: expected [ '2020-10-02T22:11:23.167Z',
  '2020-10-02T22:11:23.173Z',
  '2020-10-02T22:11:25.185Z',
  '2020-10-02T22:11:25.124Z',
  '2020-10-02T22:11:25.196Z' ] to sort of equal [ '2020-10-02T22:11:23.167Z',
  '2020-10-02T22:11:23.173Z',
  '2020-10-02T22:11:25.124Z',
  '2020-10-02T22:11:25.185Z',
  '2020-10-02T22:11:25.196Z' ]
    at Assertion.assert (/dev/shm/workspace/parallel/2/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/2/kibana/packages/kbn-expect/expect.js:244:8)
    at ensureDatetimesAreOrdered (test/alerting_api_integration/common/lib/test_assertions.ts:22:26)
    at Context.it (test/alerting_api_integration/spaces_only/tests/alerting/execution_status.ts:73:7)
  actual:
   '[\n  "2020-10-02T22:11:23.167Z"\n  "2020-10-02T22:11:23.173Z"\n  "2020-10-02T22:11:25.185Z"\n  "2020-10-02T22:11:25.124Z"\n  "2020-10-02T22:11:25.196Z"\n]',
  expected:
   '[\n  "2020-10-02T22:11:23.167Z"\n  "2020-10-02T22:11:23.173Z"\n  "2020-10-02T22:11:25.124Z"\n  "2020-10-02T22:11:25.185Z"\n  "2020-10-02T22:11:25.196Z"\n]',
  showDiff: true }

Metrics [docs]

async chunks size

id	before	after	diff
`ingestManager`	1.1MB	1.1MB	+115.0B

History

💚 Build #79310 succeeded ea55e6d
💚 Build #79187 succeeded ace7a96
💔 Build #79150 failed 846cda2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elastic#79291)

#79291) (#79404)

* master: (128 commits) add core-js production dependency (elastic#79395) Add support for sharing saved objects to all spaces (elastic#76132) [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038) load js-yaml lazily (elastic#79092) skip flaky suite (elastic#77278) Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341) [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988) [Security Solutions][Detection Engine] Updates the edit rules page to:wq! only have what is selected for editing (elastic#79233) Cleanup yarn.lock from duplicates (elastic#66617) [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052) [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291) [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358) [babel/register] remove from build (take 2) (elastic#79379) [Security Solution] Changes rules table tag display (elastic#77102) define integrationTestRoot in config file and use to define screensho… (elastic#79247) Revert "[babel/register] remove from build (elastic#79176)" skip flaky suite (elastic#75241) [Uptime] Synthetics UI (elastic#77960) [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812) [babel/register] remove from build (elastic#79176) ...

* master: (288 commits) add core-js production dependency (elastic#79395) Add support for sharing saved objects to all spaces (elastic#76132) [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038) load js-yaml lazily (elastic#79092) skip flaky suite (elastic#77278) Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341) [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988) [Security Solutions][Detection Engine] Updates the edit rules page to only have what is selected for editing (elastic#79233) Cleanup yarn.lock from duplicates (elastic#66617) [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052) [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291) [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358) [babel/register] remove from build (take 2) (elastic#79379) [Security Solution] Changes rules table tag display (elastic#77102) define integrationTestRoot in config file and use to define screensho… (elastic#79247) Revert "[babel/register] remove from build (elastic#79176)" skip flaky suite (elastic#75241) [Uptime] Synthetics UI (elastic#77960) [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812) [babel/register] remove from build (elastic#79176) ...

ghost · 2020-10-05T11:55:20Z

Hi Eric

We have found that changes for this ticket are not displayed on latest 7.10.0-SNAPSHOT Kibana cloud environment. Hence we have reported bug #79415 for the same.

Please let us know if anything is missing from our end.

ghost · 2020-10-06T09:32:20Z

Hi @EricDavisX /@nchaulet

We have validated this ticket on latest 7.10.0-SNAPSHOT kibana cloud environment with commit 2ace108

Screenshot:

We have created 03 and executed 03 testcases under Rename Fleet setup and requirement, Fleet => Central TestRun.

Query:

As per #79291_Description_screenshot, following message and button should be displayed under "Enable central management for Elastic Agents" header on Agents tab on deploy of new 7.10.0-SNAPSHOT kibana cloud environment.

Message: Central management for Elastic Agents requires an Elastic user who can create API keys and write to logs-* and metrics-*'.
Button: Button with text 'Create user and enable Agents'

However on deploy of new 7.10.0-SNAPSHOT kibana cloud environment, we observed some text changes in above message and button under "Enable central management for Elastic Agents" header on Agents tab.

Message missing 'for Elastic Agents' text is displayed i.e
Central management requires an Elastic user who can create API keys and write to logs-* and metrics-*'.
Button with text 'Create and enable central management' is displayed.

Screenshot:

Please let us know if it is the expected behavior.

nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta2 labels Oct 2, 2020

nchaulet requested a review from a team October 2, 2020 13:25

nchaulet self-assigned this Oct 2, 2020

[Ingest Manager] Rename Fleet setup and requirement, Fleet => Central…

ace7a96

… management for Elastic Agents

nchaulet force-pushed the feature-rename-agents-requirements-setup branch from 846cda2 to ace7a96 Compare October 2, 2020 15:11

jen-huang approved these changes Oct 2, 2020

View reviewed changes

...lugins/ingest_manager/public/applications/ingest_manager/sections/fleet/setup_page/index.tsx Outdated Show resolved Hide resolved

Update x-pack/plugins/ingest_manager/public/applications/ingest_manag…

ea55e6d

…er/sections/fleet/setup_page/index.tsx Co-authored-by: Jen Huang <its.jenetic@gmail.com>

dedemorton reviewed Oct 2, 2020

View reviewed changes

Apply suggestions from code review

ca18b83

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

dedemorton approved these changes Oct 2, 2020

View reviewed changes

nchaulet merged commit 92a629f into elastic:master Oct 3, 2020

nchaulet deleted the feature-rename-agents-requirements-setup branch October 3, 2020 00:11

nchaulet added a commit to nchaulet/kibana that referenced this pull request Oct 5, 2020

[Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (

827e64e

elastic#79291)

nchaulet mentioned this pull request Oct 5, 2020

[7.x] [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (#79291) #79404

Merged

nchaulet added a commit that referenced this pull request Oct 5, 2020

[Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (

5d9c0e1

#79291) (#79404)

ghost mentioned this pull request Oct 5, 2020

Old 'Enable Fleet' UI with texts and button is displayed under Agents tab #79415

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… #79291

[Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… #79291

nchaulet commented Oct 2, 2020

elasticmachine commented Oct 2, 2020

dedemorton left a comment •

edited

Loading

dedemorton Oct 2, 2020

kibanamachine commented Oct 2, 2020

Standard Out

Stack Trace

ghost commented Oct 5, 2020

ghost commented Oct 6, 2020

[Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… #79291

[Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… #79291

Conversation

nchaulet commented Oct 2, 2020

Description

UI Change

How to tests

elasticmachine commented Oct 2, 2020

dedemorton left a comment • edited Loading

Choose a reason for hiding this comment

dedemorton Oct 2, 2020

Choose a reason for hiding this comment

kibanamachine commented Oct 2, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

async chunks size

History

ghost commented Oct 5, 2020

ghost commented Oct 6, 2020

dedemorton left a comment •

edited

Loading