Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Update TLS fields used in drag-and-drop #78815

Merged
merged 3 commits into from
Oct 6, 2020
Merged

[Security Solution] Update TLS fields used in drag-and-drop #78815

merged 3 commits into from
Oct 6, 2020

Conversation

patrykkopycinski
Copy link
Contributor

Summary

Fixes #67299

Checklist

@patrykkopycinski patrykkopycinski requested review from a team as code owners September 29, 2020 16:15
@patrykkopycinski patrykkopycinski self-assigned this Sep 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
securitySolution 10.3MB 10.3MB -82.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

XavierM
XavierM approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense after I look at https://www.elastic.co/guide/en/ecs/current/ecs-tls.html

@patrykkopycinski patrykkopycinski merged commit 6f9f061 into elastic:master Oct 6, 2020
@patrykkopycinski patrykkopycinski deleted the fix/update-tls-dnd-fields branch October 6, 2020 20:06
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Oct 6, 2020
@patrykkopycinski
[Security Solution] Update TLS fields used in drag-and-drop (elastic#…
678ff3f 
…78815)
@patrykkopycinski patrykkopycinski mentioned this pull request Oct 6, 2020
Merged
patrykkopycinski added a commit that referenced this pull request Oct 6, 2020
@patrykkopycinski
[Security Solution] Update TLS fields used in drag-and-drop (#78815) (#…
a67c3eb 
…79755)
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SIEM] Network TLS table using wrong fields for drag and drop to timelines
5 participants
@patrykkopycinski @elasticmachine @kibanamachine @XavierM @MindyRS