Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Rename Ingest Manager => Fleet, Fleet => Agents in the UI #78685

Merged
merged 2 commits into from
Sep 29, 2020
Merged

[Fleet] Rename Ingest Manager => Fleet, Fleet => Agents in the UI #78685

merged 2 commits into from
Sep 29, 2020

Conversation

nchaulet
Copy link
Member

Summary

We decided to rename Ingest Manager to Fleet, also we decide to rename the Fleet tab Agents.

This PR do the change, we will need to update also the fleet requirement and setup page, but this will be in a secondary PR.

UI Change

Enrollment tokens list page

Screen Shot 2020-09-28 at 3 44 41 PM

Agent detail page

Screen Shot 2020-09-28 at 3 44 34 PM

Agent list page

Screen Shot 2020-09-28 at 3 44 26 PM

Overview page

Screen Shot 2020-09-28 at 3 43 42 PM

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta2 labels Sep 28, 2020
@nchaulet nchaulet requested a review from a team September 28, 2020 20:40
@nchaulet nchaulet self-assigned this Sep 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

jen-huang
jen-huang approved these changes Sep 28, 2020
View reviewed changes
...ns/ingest_manager/sections/fleet/components/agent_enrollment_flyout/managed_instructions.tsx
id="xpack.ingestManager.agentEnrollment.setUpFleetLink"
defaultMessage="set up Fleet"
id="xpack.ingestManager.agentEnrollment.setUpAgentsLink"
defaultMessage="set up Agents"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before enrolling agents, set up Agents. sounds weird. maybe Before enrolling agents, enable agent management. or similar would be better? we can revisit this in the follow up PR for Fleet setup page, the words here should be consistent with whatever we use for the setup page

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I will revisit it when I do the requirements page @hbharding or @dedemorton if you have suggestions here on better wording

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id value diff baseline
ingestManager 1.1MB +1.0B 1.1MB

page load bundle size

id value diff baseline
ingestManager 521.2KB -321.0B 521.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nchaulet nchaulet merged commit cfa5074 into elastic:master Sep 29, 2020
@nchaulet nchaulet deleted the feature-rename-fleet-ui branch September 29, 2020 14:06
@nchaulet nchaulet mentioned this pull request Sep 29, 2020
Merged
nchaulet added a commit to nchaulet/kibana that referenced this pull request Sep 29, 2020
@nchaulet
[Fleet] Rename Ingest Manager => Fleet, Fleet => Agents in the UI (el…
3c3bd13 
…astic#78685)
nchaulet added a commit that referenced this pull request Sep 29, 2020
@nchaulet
[Fleet] Rename Ingest Manager => Fleet, Fleet => Agents in the UI (#7…
5e87561 
…8685) (#78775)
phillipb added a commit to phillipb/kibana that referenced this pull request Sep 29, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into add-anomalies…
f7e5f99 
…-to-timeline

* 'master' of github.com:elastic/kibana: (22 commits)
  update apm index pattern (elastic#78732)
  78024: move transform out of dataset (elastic#78216)
  [QA][Code Coverage] Upload the coverage static site before ingestion (elastic#78695)
  [Discover] Make _source field not clickable (elastic#78698)
  [Fleet] Rename Ingest Manager => Fleet, Fleet => Agents in the UI (elastic#78685)
  [APM] Review feedback from distribution + transaction metrics (elastic#78752)
  [Ingest pipelines] Add ability to stop pipeline simulation  (elastic#78183)
  [CSM] Fix core vital legend background (elastic#78273)
  [Usage Collection] [schema] Support spreads + `canvas` definition (elastic#78481)
  fix lodash imports (elastic#78456)
  [Maps] Add layer type preview icons (elastic#78650)
  [APM] Use transaction metrics for distribution charts (elastic#78484)
  [Uptime] Ml anomaly alert edit (elastic#76909)
  [ML] Limit exposing shared static code through ml/public/index.ts. (elastic#77745)
  making expression debug info serializable (elastic#78727)
  fix lodahs imports in app-arch code (elastic#78582)
  Make Field a React.lazy export (elastic#78483)
  [Security Solution] Improves detections tests (elastic#77295)
  [TSVB] Different field format on different series is ignored (elastic#78138)
  RFC: Improve saved object migrations (elastic#66056)
  ...
@ghost
Copy link

ghost commented Oct 5, 2020

Hi Eric

We have executed 03 testcases under [Fleet] Rename Ingest Manager => Fleet, Fleet => Agents in the UI TestRun and added a note in 144 testcases for Ingest manager link updated to Fleet and Fleet tab renamed to Agents tab.

Please let us know if anything else is required from our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen-huang jen-huang jen-huang approved these changes

Assignees

@nchaulet nchaulet

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nchaulet @elasticmachine @kibanamachine @jen-huang