Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Resolver]Add backdrop to pills #78625

Merged
merged 2 commits into from
Sep 30, 2020
Merged

[Security Solution][Resolver]Add backdrop to pills #78625

merged 2 commits into from
Sep 30, 2020

Conversation

bkimmel
Copy link
Contributor

@bkimmel bkimmel commented Sep 28, 2020

Summary

This PR:

  1. Adds a backdrop blur between the pills to prevent distraction from the underlying edge label text.
    image
  2. Organize components to fit with team standard of exporting styled components from styles
  3. Correct a comment on the component

For maintainers

@bkimmel bkimmel requested review from a team as code owners September 28, 2020 15:32
@bkimmel bkimmel added v7.10.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Resolver Security Solution Resolver feature Team:Endpoint Data Visibility Team managing the endpoint resolver labels Sep 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Resolver)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

@bkimmel
Copy link
Contributor Author

bkimmel commented Sep 28, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id value diff baseline
securitySolution 10.2MB +52.0B 10.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bkimmel
Copy link
Contributor Author

bkimmel commented Sep 28, 2020

Holding for UX/Design approval ( @lindseypoli @monina-n @marrasherrier )

michaelolo24
michaelolo24 approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really sleek, 👍

@bkimmel bkimmel merged commit b1e60a6 into elastic:master Sep 30, 2020
@bkimmel bkimmel deleted the resolver/pills-add-backdrop-and-update-comment branch September 30, 2020 00:47
@bkimmel bkimmel mentioned this pull request Sep 30, 2020
Merged
yctercero pushed a commit to yctercero/kibana that referenced this pull request Sep 30, 2020
@bkimmel @elasticmachine @yctercero
[Security Solution][Resolver]Add backdrop to pills (elastic#78625)
f793c52 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
bkimmel added a commit that referenced this pull request Sep 30, 2020
@bkimmel @elasticmachine
[Security Solution][Resolver]Add backdrop to pills (#78625) (#78948)
b7259e6 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
phillipb added a commit to phillipb/kibana that referenced this pull request Sep 30, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into override-anom…
a3da4bc 
…aly-detection-partition-field

* 'master' of github.com:elastic/kibana: (37 commits)
  [UiActions] Don't throw an error if there are no compatible actions to execute (elastic#78917)
  [Observability] Kibana nav when docked overlaps the content of the pages. (elastic#78593)
  Invalid `searchSourceJSON` causes saved object migration to fail (elastic#78535)
  update vega version (elastic#78390)
  Fix warning text doesn't get displayed on filters with custom filter name (elastic#78617)
  [ILM] Data tier notices should reflect tier preferences (elastic#78398)
  [APM] Service Map: `Not Defined` option doesn't work properly (elastic#77757)
  Improve invalid field error message at search.aggs.param_types.field (elastic#78587)
  Remove isDeprecated flag on visType (elastic#78820)
  Remove unused elasticsearch.preserverHost setting (elastic#78608)
  Fix condition and adjust tests (elastic#78898)
  [UX] Add percentile selector (elastic#78562)
  [ML] Replace use of rest_total_hits_as_int with track_total_hits (elastic#78423)
  expression service docs (elastic#78774)
  [Functional] Wait for the page to load and then click the new vis button (elastic#78725)
  [TSVB] No data in visualizations with annotations (elastic#78794)
  [kbn/ui-shared-deps] track asset sizes (elastic#78718)
  delete target before building (elastic#78665)
  Move indexPattern.popularizeField into discover (elastic#77668)
  [Security Solution][Resolver]Add backdrop to pills (elastic#78625)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oatkiller oatkiller oatkiller approved these changes

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@marrasherrier marrasherrier marrasherrier approved these changes

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

Assignees
No one assigned
Labels
Feature:Resolver Security Solution Resolver feature release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Data Visibility Team managing the endpoint resolver v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bkimmel @elasticmachine @kibanamachine @oatkiller @michaelolo24 @marrasherrier @jonathan-buttner