Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [shared-ui-deps] use a single global version of lodash (#78100) #78454

Merged
merged 1 commit into from
Sep 24, 2020
Merged

[7.x] [shared-ui-deps] use a single global version of lodash (#78100) #78454

merged 1 commit into from
Sep 24, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Sep 24, 2020

Backports the following commits to 7.x:

@spalger
[shared-ui-deps] use a single global version of lodash (elastic#78100)
54590a6 
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	packages/kbn-pm/dist/index.js
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id value diff baseline
advancedSettings 50 -3 53
apm 1251 -1 1252
beatsManagement 302 -2 304
canvas 1132 -1 1133
charts 31 -3 34
console 160 -3 163
core 561 -1 562
crossClusterReplication 159 -1 160
dashboard 171 -1 172
dashboardEnhanced 26 -3 29
dashboardMode 4 -3 7
data 568 -1 569
dataEnhanced 17 -3 20
devTools 17 -3 20
discover 251 -3 254
embeddable 71 -3 74
enterpriseSearch 247 -1 248
esUiShared 227 -2 229
expressions 107 -2 109
fileUpload 24 -3 27
graph 180 -1 181
grokdebugger 75 -1 76
home 211 -2 213
indexLifecycleManagement 204 -1 205
indexManagement 504 -1 505
indexPatternManagement 211 -3 214
infra 1098 -1 1099
inputControlVis 41 -3 44
inspector 62 -3 65
kibanaLegacy 122 -2 124
kibanaReact 289 -1 290
kibanaUtils 189 -1 190
lens 474 -2 476
logstash 193 -2 195
management 43 -3 46
maps 694 -1 695
mapsLegacy 139 -1 140
ml 1407 -1 1408
monitoring 624 -2 626
navigation 23 -3 26
observability 87 -3 90
painlessLab 40 -3 43
regionMap 14 -3 17
remoteClusters 141 -1 142
reporting 45 -1 46
rollup 179 -1 180
savedObjects 43 -3 46
savedObjectsManagement 135 -2 137
searchprofiler 73 -3 76
security 454 -1 455
securitySolution 1962 -3 1965
snapshotRestore 168 -3 171
spaces 224 -3 227
tileMap 20 -3 23
timelion 102 -3 105
triggers_actions_ui 253 -8 261
uiActions 29 -3 32
upgradeAssistant 118 -2 120
uptime 512 -1 513
visDefaultEditor 238 -2 240
visTypeMetric 25 -3 28
visTypeTable 42 -3 45
visTypeTimelion 45 -3 48
visTypeTimeseries 465 -1 466
visTypeVega 78 -2 80
visTypeVislib 275 -1 276
visualizations 133 -2 135
visualize 207 -2 209
watcher 223 -2 225
total -149

async chunks size

id value diff baseline
advancedSettings 63.8KB +72.0B 63.8KB
apm 4.1MB -137.4KB 4.2MB
beatsManagement 408.6KB +598.0B 408.0KB
canvas 1.4MB +2.5KB 1.4MB
console 993.8KB -140.4KB 1.1MB
crossClusterReplication 461.7KB +595.0B 461.1KB
discover 438.5KB +1.3KB 437.2KB
enterpriseSearch 488.6KB -142.7KB 631.3KB
fileUpload 576.8KB -142.7KB 719.6KB
graph 1.3MB -142.2KB 1.4MB
grokdebugger 568.8KB -142.3KB 711.0KB
home 425.1KB -142.5KB 567.7KB
indexLifecycleManagement 229.2KB +691.0B 228.5KB
indexManagement 1.1MB +778.0B 1.1MB
indexPatternManagement 664.5KB -142.7KB 807.2KB
infra 4.0MB +7.3KB 3.9MB
kibanaReact 389.0KB +384.0B 388.6KB
lens 33.1KB +163.0B 32.9KB
logstash 217.1KB +209.0B 216.9KB
management 33.8KB -143.0KB 176.8KB
maps 3.3MB +4.7KB 3.3MB
ml 8.1MB +4.8KB 8.1MB
monitoring 1.2MB +4.4KB 1.2MB
observability 155.1KB -142.9KB 298.0KB
painlessLab 38.7KB -143.3KB 182.0KB
remoteClusters 231.7KB -142.4KB 374.0KB
rollup 330.1KB +859.0B 329.2KB
savedObjectsManagement 204.7KB +425.0B 204.2KB
searchprofiler 572.1KB -142.8KB 714.9KB
security 1.0MB +773.0B 1.0MB
securitySolution 10.2MB +46.0KB 10.2MB
snapshotRestore 620.3KB -143.2KB 763.5KB
timelion 455.5KB -141.8KB 597.4KB
triggers_actions_ui 890.9KB -85.2KB 976.1KB
upgradeAssistant 188.1KB -142.6KB 330.6KB
uptime 1.5MB -142.3KB 1.6MB
visTypeTable 6.7KB +48.0B 6.6KB
visTypeTimeseries 1.8MB +3.7KB 1.8MB
visTypeVega 1.4MB +586.0B 1.4MB
visualize 269.1KB -142.5KB 411.6KB
watcher 461.8KB -141.0KB 602.8KB
total -2.6MB

page load bundle size

id value diff baseline
advancedSettings 838.5KB -142.9KB 981.4KB
apm 44.1KB +66.0B 44.0KB
beatsManagement 439.1KB -142.5KB 581.6KB
canvas 1.2MB -140.0KB 1.3MB
charts 344.2KB -142.4KB 486.6KB
console 30.4KB +66.0B 30.3KB
core 1.1MB -141.6KB 1.2MB
crossClusterReplication 49.2KB -142.9KB 192.1KB
dashboard 567.8KB -141.5KB 709.3KB
dashboardEnhanced 43.1KB -142.8KB 185.9KB
dashboardMode 7.5KB -142.9KB 150.4KB
data 1.3MB -134.6KB 1.5MB
dataEnhanced 34.5KB -142.7KB 177.2KB
devTools 23.2KB -142.9KB 166.1KB
discover 87.9KB -142.9KB 230.7KB
embeddable 219.5KB -142.8KB 362.3KB
enterpriseSearch 24.0KB +40.0B 23.9KB
esUiShared 851.6KB -142.6KB 994.2KB
expressions 204.1KB -142.5KB 346.6KB
fileUpload 9.5KB +66.0B 9.4KB
graph 15.8KB +66.0B 15.8KB
grokdebugger 11.5KB +66.0B 11.4KB
home 26.7KB +66.0B 26.7KB
indexLifecycleManagement 89.3KB -142.8KB 232.1KB
indexManagement 626.0KB -142.7KB 768.6KB
indexPatternManagement 136.1KB +66.0B 136.0KB
infra 134.5KB -142.8KB 277.3KB
inputControlVis 154.1KB -142.1KB 296.2KB
inspector 134.6KB -142.9KB 277.4KB
kibanaLegacy 90.5KB -142.1KB 232.6KB
kibanaReact 124.0KB -142.6KB 266.7KB
kibanaUtils 177.0KB -141.9KB 318.9KB
lens 1.0MB -141.6KB 1.2MB
logstash 37.6KB -142.4KB 180.1KB
management 30.4KB +26.0B 30.4KB
maps 158.8KB -142.8KB 301.6KB
mapsLegacy 816.2KB -141.7KB 957.9KB
ml 731.2KB -142.3KB 873.6KB
monitoring 160.3KB -142.5KB 302.7KB
navigation 21.9KB -142.8KB 164.7KB
observability 52.4KB +66.0B 52.3KB
painlessLab 161.0KB +26.0B 161.0KB
regionMap 302.9KB -142.7KB 445.6KB
remoteClusters 35.5KB +66.0B 35.4KB
reporting 162.3KB -142.1KB 304.3KB
rollup 80.3KB -142.8KB 223.1KB
savedObjects 93.2KB -142.6KB 235.8KB
savedObjectsManagement 83.5KB -142.7KB 226.2KB
searchprofiler 50.9KB +66.0B 50.8KB
security 163.3KB -142.3KB 305.7KB
securitySolution 567.3KB -225.6KB 792.8KB
snapshotRestore 62.7KB +26.0B 62.6KB
spaces 346.9KB -142.8KB 489.6KB
tileMap 314.7KB -142.5KB 457.2KB
timelion 14.6KB +66.0B 14.5KB
triggers_actions_ui 145.3KB -142.9KB 288.2KB
uiActions 78.2KB -142.8KB 221.0KB
upgradeAssistant 64.2KB +66.0B 64.2KB
uptime 25.2KB +66.0B 25.2KB
visDefaultEditor 397.8KB -141.7KB 539.5KB
visTypeMetric 51.3KB -142.8KB 194.1KB
visTypeTable 78.0KB -142.6KB 220.6KB
visTypeTimelion 183.4KB -142.3KB 325.7KB
visTypeTimeseries 136.9KB -142.8KB 279.7KB
visTypeVega 134.6KB -142.8KB 277.5KB
visTypeVislib 812.2KB -139.0KB 951.1KB
visualizations 271.2KB -141.2KB 412.4KB
visualize 41.4KB +66.0B 41.3KB
total -7.0MB

distributable file count

id value diff baseline
default 47556 -18 47574
oss 28304 -3 28307
total -21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 8a65530 into elastic:7.x Sep 24, 2020
@spalger spalger deleted the backport/7.x/pr-78100 branch September 24, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spalger @kibanamachine