Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mappings editor] Add support for version field type #78206

Merged
merged 4 commits into from
Oct 1, 2020
Merged

[Mappings editor] Add support for version field type #78206

merged 4 commits into from
Oct 1, 2020

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Sep 22, 2020 •
edited
Loading

Fixes #77490

Note: You made need to build ES from source in order to test. Support for the version field was added via elastic/elasticsearch#59773.

Release note

The mappings editor in the Index Templates UI now supports configuring the version field type.

Screen Shot 2020-09-22 at 4 07 28 PM

@alisonelizabeth alisonelizabeth added release_note:enhancement Feature:Index Management Index and index templates UI v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Mappings Editor Index mappings editor UI v7.10.0 labels Sep 22, 2020
@alisonelizabeth alisonelizabeth marked this pull request as ready for review September 23, 2020 13:49
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner September 23, 2020 13:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth requested review from sebelga and removed request for yuliacech September 30, 2020 18:06
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id value diff baseline
indexManagement 509 +1 508

async chunks size

id value diff baseline
indexManagement 1.6MB +1.6KB 1.6MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sebelga
sebelga approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @alisonelizabeth ! LGTM 👍

@alisonelizabeth alisonelizabeth merged commit 4fe7625 into elastic:master Oct 1, 2020
@alisonelizabeth alisonelizabeth deleted the feature/mappings_editor/version_field branch October 1, 2020 12:44
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Oct 1, 2020
@alisonelizabeth
[Mappings editor] Add support for version field type (elastic#78206)
ee2b30c
@alisonelizabeth alisonelizabeth mentioned this pull request Oct 1, 2020
Merged
alisonelizabeth added a commit that referenced this pull request Oct 1, 2020
@alisonelizabeth
[Mappings editor] Add support for version field type (#78206) (#79111)
14bd064
@bczifra bczifra mentioned this pull request May 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

Assignees
No one assigned
Labels
Feature:Index Management Index and index templates UI Feature:Mappings Editor Index mappings editor UI release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mappings editor] Add UI form for version field type
4 participants
@alisonelizabeth @elasticmachine @kibanamachine @sebelga