Jest multi-project configuration #77894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
force-pushed
the
jest-multi
branch
2 times, most recently
from
908b73d
to
07bce70
Compare
tylersmalley
force-pushed
the
jest-multi
branch
17 times, most recently
from
8b38a6f
to
827ce4b
Compare
tylersmalley
force-pushed
the
jest-multi
branch
6 times, most recently
from
126dd31
to
1a491fc
Compare
tylersmalley
force-pushed
the
jest-multi
branch
from
1a491fc
to
219d160
Compare
tylersmalley
force-pushed
the
jest-multi
branch
from
219d160
to
1de4ae4
Compare
1 task
flash1293
approved these changes
Dec 1, 2020
weltenwort
reviewed
Dec 1, 2020
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
cee-chen
approved these changes
Dec 1, 2020
nchaulet
approved these changes
Dec 1, 2020
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
spalger
reviewed
Dec 1, 2020
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
spalger
approved these changes
Dec 1, 2020
|
@weltenwort, good catch - I have resolved the issue of the test reporter. |
sorenlouv
reviewed
Dec 2, 2020
| @@ -1,1995 +0,0 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
|
|
|||
| exports[`Service Maps with a trial license /api/apm/service-map when there is data returns service map elements filtering by environment not defined 1`] = ` | |||
There was a problem hiding this comment.
@dgieselaar Does this look okay to you? (removing all the snapshots)
There was a problem hiding this comment.
Jest integration tests donot currently run for X-Pack - I have a draft PR up showing that removing these does not effect the current CI jobs. #84783
mshustov
approved these changes
Dec 2, 2020
|
@elasticmachine merge upstream All teams affected by more than just adding a |
andrewvc
approved these changes
Dec 2, 2020
myasonik
approved these changes
Dec 2, 2020
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Dec 2, 2020
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> # Conflicts: # src/dev/code_coverage/ingest_coverage/integration_tests/team_assignment.test.js # src/plugins/console/jest.config.js # x-pack/plugins/canvas/scripts/jest.js
tylersmalley
pushed a commit
that referenced
this pull request
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72569
Closes #75202
Closes #41129
Blocked on:
Overrides for tests which are incompatible with jest-circus added in 72d7e42. A PR is currently open (#82280) to resolve these incompatabilities but should not block this PR.
A CI check has been added to ensure that no new tests are added that are not covered by the main config.
Reviewing:
The commits have been split out to isolate the changes consisting of the auto-generated
jest.config.jsfiles in 7518751.