Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Transforms: Fixes styling of preview grid pagination in summary step #77789

Merged
merged 1 commit into from
Sep 18, 2020
Merged

[ML] Transforms: Fixes styling of preview grid pagination in summary step #77789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions ...sform/public/app/sections/create_transform/components/step_define/step_define_summary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import React, { Fragment, FC } from 'react';

import { i18n } from '@kbn/i18n';

import { EuiCodeBlock, EuiForm, EuiFormRow, EuiSpacer, EuiText } from '@elastic/eui';
import { EuiCodeBlock, EuiForm, EuiFormRow, EuiSpacer } from '@elastic/eui';

import { dictionaryToArray } from '../../../../../../common/types/common';

Expand Down Expand Up @@ -132,23 +132,21 @@ export const StepDefineSummary: FC<Props> = ({
</EuiFormRow>

<EuiSpacer size="m" />
<EuiText>
<DataGrid
{...pivotPreviewProps}
copyToClipboard={getPivotPreviewDevConsoleStatement(previewRequest)}
copyToClipboardDescription={i18n.translate(
'xpack.transform.pivotPreview.copyClipboardTooltip',
{
defaultMessage: 'Copy Dev Console statement of the pivot preview to the clipboard.',
}
)}
dataTestSubj="transformPivotPreview"
title={i18n.translate('xpack.transform.pivotPreview.PivotPreviewTitle', {
defaultMessage: 'Transform pivot preview',
})}
toastNotifications={toastNotifications}
/>
</EuiText>
<DataGrid
{...pivotPreviewProps}
copyToClipboard={getPivotPreviewDevConsoleStatement(previewRequest)}
copyToClipboardDescription={i18n.translate(
'xpack.transform.pivotPreview.copyClipboardTooltip',
{
defaultMessage: 'Copy Dev Console statement of the pivot preview to the clipboard.',
}
)}
dataTestSubj="transformPivotPreview"
title={i18n.translate('xpack.transform.pivotPreview.PivotPreviewTitle', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant to this PR at all, but the first time I see a translation key starting with a capital letter 👀

defaultMessage: 'Transform pivot preview',
})}
toastNotifications={toastNotifications}
/>
</EuiForm>
</div>
);
Expand Down