Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Detections] Remove file validation on import route #77770

Merged
merged 5 commits into from
Sep 17, 2020
Merged

[Security Solution] [Detections] Remove file validation on import route #77770

merged 5 commits into from
Sep 17, 2020
+99 −18

Commits on Sep 17, 2020

  1. utlize schema.any() for validation on file in body of import rules re… 

    …quest, adds new functional tests and unit tests to make sure we can reach and don't go past bounds. These tests would have helped uncover performance issues io-ts gave us with validating the import rules file object
    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    01800d0 View commit details
    Browse the repository at this point in the history

  2. fix type check failure

    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    e267e88 View commit details
    Browse the repository at this point in the history

  3. updates getSimpleRule and getSimpleRuleAsNdjson to accept an enabled … 

    …param defaulted to false
    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    fe888cf View commit details
    Browse the repository at this point in the history

  4. updates comments in e2e tests for import rules route

    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    acfb15d View commit details
    Browse the repository at this point in the history

  5. fix tests after adding enabled boolean in test utils

    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    dd29bed View commit details
    Browse the repository at this point in the history