Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Service Map: Not Defined option doesn't work properly #77483

Merged
merged 1 commit into from
Sep 16, 2020
Merged

[APM] Service Map: Not Defined option doesn't work properly #77483

merged 1 commit into from
Sep 16, 2020

Conversation

cauemarcondes
Copy link
Contributor

closes #77332

Screenshot 2020-09-15 at 14 56 18

@cauemarcondes cauemarcondes requested a review from a team as a code owner September 15, 2020 14:01
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 89af7e6 into elastic:master Sep 16, 2020
@cauemarcondes cauemarcondes deleted the apm-servicemap-env branch September 16, 2020 08:41
@cauemarcondes cauemarcondes mentioned this pull request Sep 16, 2020
Closed
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Sep 16, 2020
@cauemarcondes
showing service maps when filte by environment not defined (elastic#7…
32fb9c6 
…7483)
@sorenlouv sorenlouv self-assigned this Sep 16, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 16, 2020
@gmmorris
Merge branch 'master' into alerts/alerting-exempt-rbac-remnant
c051d65 
* master: (55 commits)
  [Grok] Fix missing error message in error toasts (elastic#77499)
  [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563)
  [ML] fix type in apply_influencer_filters_action (elastic#77495)
  [Lens] create reusable component for filters and range aggregation (elastic#77453)
  fix eslint violations
  Collapse alert chart previews by default (elastic#77479)
  [ML] Fixing field caps wrapper endpoint (elastic#77546)
  showing service maps when filte by environment not defined (elastic#77483)
  [Lens] Settings panel redesign and separate settings per y axis (elastic#76373)
  log request body in new ES client (elastic#77150)
  use `navigateToUrl` to navigate to recent nav links (elastic#77446)
  Move core config service to `kbn/config` package (elastic#76874)
  [UBI] Copy license to /licenses folder (elastic#77563)
  Skip flaky Events Viewer Cypress test
  [Lens] Remove dynamic names in telemetry fields (elastic#76988)
  [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366)
  [Enterprise Search] Add flag to restrict width of layout (elastic#77539)
  [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967)
  [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090)
  [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 16, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
7bfbad5 
* master: (54 commits)
  [Grok] Fix missing error message in error toasts (elastic#77499)
  [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563)
  [ML] fix type in apply_influencer_filters_action (elastic#77495)
  [Lens] create reusable component for filters and range aggregation (elastic#77453)
  fix eslint violations
  Collapse alert chart previews by default (elastic#77479)
  [ML] Fixing field caps wrapper endpoint (elastic#77546)
  showing service maps when filte by environment not defined (elastic#77483)
  [Lens] Settings panel redesign and separate settings per y axis (elastic#76373)
  log request body in new ES client (elastic#77150)
  use `navigateToUrl` to navigate to recent nav links (elastic#77446)
  Move core config service to `kbn/config` package (elastic#76874)
  [UBI] Copy license to /licenses folder (elastic#77563)
  Skip flaky Events Viewer Cypress test
  [Lens] Remove dynamic names in telemetry fields (elastic#76988)
  [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366)
  [Enterprise Search] Add flag to restrict width of layout (elastic#77539)
  [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967)
  [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090)
  [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058)
  ...
@cauemarcondes cauemarcondes mentioned this pull request Sep 16, 2020
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Sep 16, 2020
@cauemarcondes
showing service maps when filte by environment not defined (elastic#7…
16a3b0e 
…7483)
cauemarcondes added a commit that referenced this pull request Sep 16, 2020
@cauemarcondes
[7.x] showing service maps when filte by environment not defined (#77483
cb7ba1f 
) | Fixing service maps API test (#77586) (#77603)

* showing service maps when filte by environment not defined (#77483)

* Fixing service maps API test (#77586)

* fixing api tests

* fixing api tests
# Conflicts:
#	x-pack/test/apm_api_integration/trial/tests/service_maps/service_maps.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 16, 2020
@gmmorris
Merge branch 'master' into actions/test-connector
45a2dd5 
* master: (76 commits)
  Fixing service maps API test (elastic#77586)
  [Grok] Fix missing error message in error toasts (elastic#77499)
  [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563)
  [ML] fix type in apply_influencer_filters_action (elastic#77495)
  [Lens] create reusable component for filters and range aggregation (elastic#77453)
  fix eslint violations
  Collapse alert chart previews by default (elastic#77479)
  [ML] Fixing field caps wrapper endpoint (elastic#77546)
  showing service maps when filte by environment not defined (elastic#77483)
  [Lens] Settings panel redesign and separate settings per y axis (elastic#76373)
  log request body in new ES client (elastic#77150)
  use `navigateToUrl` to navigate to recent nav links (elastic#77446)
  Move core config service to `kbn/config` package (elastic#76874)
  [UBI] Copy license to /licenses folder (elastic#77563)
  Skip flaky Events Viewer Cypress test
  [Lens] Remove dynamic names in telemetry fields (elastic#76988)
  [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366)
  [Enterprise Search] Add flag to restrict width of layout (elastic#77539)
  [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967)
  [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090)
  ...
@cauemarcondes cauemarcondes mentioned this pull request Sep 17, 2020
Merged
@sorenlouv sorenlouv removed their assignment Oct 7, 2020
@dgieselaar dgieselaar self-assigned this Oct 16, 2020
@dgieselaar
Copy link
Member

A little hard to test fully/visually, but had a look at a couple of environments and it seems to filter the nodes correctly based on the environment selector, including Not defined.

@dgieselaar dgieselaar added the apm:test-plan-done Pull request that was successfully tested during the test plan label Oct 16, 2020
@dgieselaar dgieselaar removed their assignment Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

@sorenlouv sorenlouv sorenlouv left review comments

@dgieselaar dgieselaar dgieselaar left review comments

Assignees
No one assigned
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan release_note:fix Team:APM All issues that need APM UI Team support v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Service Map: Not Defined option doesn't work properly
6 participants
@cauemarcondes @elasticmachine @kibanamachine @dgieselaar @smith @sorenlouv