Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace FetchOptions with ISearchOptions #76538

Merged
merged 3 commits into from
Sep 3, 2020
Merged

Replace FetchOptions with ISearchOptions #76538

merged 3 commits into from
Sep 3, 2020

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Sep 2, 2020 •
edited
Loading

Summary

  • Merge the client and server side definitions of ISearchOptions into the common folder. The type is still re-exported from both the public and server folders.
  • Replace FetchOptions (Used by SearchSource) with ISearchOptions (Used by the search API) and update usage.

This was done in order to simplify adding new options to SearchSource and search apis.

Dev Docs

The FetchOptions type was removed, use the ISearchOptions type instead.
The ISearchOptions signal option was renamed to abortSignal.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lizozom lizozom added Feature:Search Querying infrastructure in Kibana v8.0.0 Team:AppArch v7.10.0 labels Sep 2, 2020
@lizozom lizozom requested a review from a team as a code owner September 2, 2020 16:36
@lizozom lizozom requested a review from a team September 2, 2020 16:36
@lizozom lizozom requested review from a team as code owners September 2, 2020 16:36
@lizozom lizozom self-assigned this Sep 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom added release_note:skip Skip the PR/issue when compiling release notes release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. and removed release_note:skip Skip the PR/issue when compiling release notes labels Sep 2, 2020
patrykkopycinski
patrykkopycinski approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIEM changes LGTM! Thank you @lizozom 💪

@lizozom lizozom changed the title Replace FetchOptions with ISearchOptions and update usage Replace FetchOptions with ISearchOptions Sep 2, 2020
lukeelmers
lukeelmers approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes here LGTM. Should we also update the dev docs issue to indicate that signal has been renamed abortSignal?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 9.8MB +35.0B 9.8MB

page load bundle size

id value diff baseline
data 1.4MB -42.0B 1.4MB
visTypeVega 665.5KB +5.0B 665.5KB
total -37.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kertal
kertal approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KibanaApp owned code LGTM, just one file containing the rename of signal -> `abortSignal, didn't test

@lizozom lizozom merged commit 411048a into elastic:master Sep 3, 2020
@lizozom lizozom mentioned this pull request Sep 3, 2020
Merged
lizozom added a commit to lizozom/kibana that referenced this pull request Sep 3, 2020
@lizozom
Replace FetchOptions with ISearchOptions (elastic#76538)
6166e07 
* Replace FetchOptions with ISearchOptions and update usage

* Merge the client and server ISearchOption types into common

* docs
@lizozom lizozom mentioned this pull request Sep 3, 2020
Merged
7 tasks
lizozom added a commit that referenced this pull request Sep 3, 2020
@lizozom
[7.x] Replace FetchOptions with ISearchOptions (#76538) (#76612)
8ed1ae3 
* Replace FetchOptions with ISearchOptions (#76538)

* Replace FetchOptions with ISearchOptions and update usage

* Merge the client and server ISearchOption types into common

* docs

* Update index.tsx

Abort signal

* Update index.tsx
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 3, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-pipeli…
81bad4f 
…nes/processors-forms-k-s

* 'master' of github.com:elastic/kibana: (216 commits)
  [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558)
  [Security Solution] add an excess validation instead of the exact match (elastic#76472)
  Introduce TS incremental builds & move src/test_utils to TS project  (elastic#76082)
  fix bad merge (elastic#76629)
  [Newsfeed] Ensure the version format when calling the API (elastic#76381)
  remove server_extensions mixin (elastic#76606)
  Remove legacy applications and legacy mode (elastic#75987)
  [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749)
  Replace FetchOptions with ISearchOptions (elastic#76538)
  Move streams utils to the core  (elastic#76397)
  [Ingest Manager] Wording & linking improvements (elastic#76284)
  remove legacy kibana plugin (elastic#76064)
  [Form lib] Fix regression on field not being validated after reset to its default value. (elastic#76379)
  Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (elastic#76482)
  [APM] Service maps layout enhancements (elastic#76481)
  [Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript (elastic#76586)
  [Security Solution][Exceptions] - Updates enum schema and tests (elastic#76544)
  Index Pattern class - remove toJSON and toString (elastic#76246)
  skip failing suite (elastic#76581)
  Split up and clarify Enterprise Search codeowners (elastic#76580)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processor_settings_fields.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/foreach.tsx
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 3, 2020
@jloleysens
Merge branch 'ingest-pipelines/processors-forms-k-s' of github.com:jl…
480523f 
…oleysens/kibana into ingest-pipelines/processors-forms-k-s

* 'ingest-pipelines/processors-forms-k-s' of github.com:jloleysens/kibana: (216 commits)
  [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558)
  [Security Solution] add an excess validation instead of the exact match (elastic#76472)
  Introduce TS incremental builds & move src/test_utils to TS project  (elastic#76082)
  fix bad merge (elastic#76629)
  [Newsfeed] Ensure the version format when calling the API (elastic#76381)
  remove server_extensions mixin (elastic#76606)
  Remove legacy applications and legacy mode (elastic#75987)
  [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749)
  Replace FetchOptions with ISearchOptions (elastic#76538)
  Move streams utils to the core  (elastic#76397)
  [Ingest Manager] Wording & linking improvements (elastic#76284)
  remove legacy kibana plugin (elastic#76064)
  [Form lib] Fix regression on field not being validated after reset to its default value. (elastic#76379)
  Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (elastic#76482)
  [APM] Service maps layout enhancements (elastic#76481)
  [Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript (elastic#76586)
  [Security Solution][Exceptions] - Updates enum schema and tests (elastic#76544)
  Index Pattern class - remove toJSON and toString (elastic#76246)
  skip failing suite (elastic#76581)
  Split up and clarify Enterprise Search codeowners (elastic#76580)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees

@lizozom lizozom

Labels
Feature:Search Querying infrastructure in Kibana release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lizozom @elasticmachine @kibanamachine @kertal @lukeelmers @patrykkopycinski