Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.9] [Ingest Manager] Improve agent vs kibana version checks (#76238) #76490

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Sep 2, 2020

Backports the following commits to 7.9:

* Add logic spec'd in issue comments. Tests pass.

* Change fn to accept 1 (opt 2) string vs object

* Add tests based on issue comments

* Change expected error message in test

* Capitalize Kibana in error message

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@jfsiii jfsiii added backport Team:Fleet Team label for Observability Data Collection Fleet team labels Sep 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jen-huang
Copy link
Contributor

@jfsiii Is there something specified you want reviewed for this backport and #76488 before merging? The code diffs look the same as original PR.

@jfsiii jfsiii merged commit 5beb515 into elastic:7.9 Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants