Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] remove region/coordinate-maps visualizations from sample data #76399

Merged
merged 4 commits into from
Sep 3, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Sep 1, 2020

Fixes #71143

PR replaces region map visualizations with vega visualizations in sample data. These provide examples of how to make maps with vega with labels and tooltips

Screen Shot 2020-09-01 at 9 35 13 AM

Screen Shot 2020-09-01 at 9 27 31 AM

Screen Shot 2020-09-01 at 8 49 00 AM

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Sep 2, 2020

@elasticmachine merge upstream

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really good imho

fwiw, I would add an example of graduated colors too, since it's something the old coordinate-map vizzes did as well.

e.g.

 scales: [
    {
      name: gridSize
      type: linear
      domain: {
        data: table
        field: doc_count
      }
      range: [
        50
        1000
      ]
    }
    {
      name: bubbleColor
      type: linear
      domain: {
        data: table
        field: doc_count
      }
      range: ["#ff7f0e","#e7ba52","#17becf"]
    }
  ]
  marks: [
    {
      name: gridMarker
      type: symbol
      from: {
        data: table
      }
      encode: {
        update: {
          fill: {
            scale: bubbleColor
            field: doc_count
          }
          size: {
            scale: gridSize
            field: doc_count
          }
          xc: {
            signal: datum.x
          }
          yc: {
            signal: datum.y
          }
          tooltip: {
            signal: "{flights: datum.doc_count}"
          }
        }
      }
    }
  ]

@nreese
Copy link
Contributor Author

nreese commented Sep 3, 2020

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Sep 3, 2020

fwiw, I would add an example of graduated colors too, since it's something the old coordinate-map vizzes did as well.

Great idea. I updated logs map with color scale

Screen Shot 2020-09-03 at 1 04 52 PM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 1be6d69 into elastic:master Sep 3, 2020
nreese added a commit to nreese/kibana that referenced this pull request Sep 3, 2020
…lastic#76399)

* [Maps] remove region/coordinate-maps visualizations from sample data

* add color scale to logs vega map

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese added a commit that referenced this pull request Sep 4, 2020
…76399) (#76718)

* [Maps] remove region/coordinate-maps visualizations from sample data

* add color scale to logs vega map

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 4, 2020
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (75 commits)
  Remove legacy ui-apps-mixin (elastic#76604)
  remove unused test_utils (elastic#76528)
  [ML] Functional tests - add UI permission tests (elastic#76368)
  [APM] @ts-error -> @ts-expect-error (elastic#76492)
  [APM] Avoid negative offset for error marker on timeline (elastic#76638)
  [Reporting] rename interfaces to align with task manager integration (elastic#76716)
  Revert back ESO migration for alerting, added try/catch logic to avoid failing Kibana on start (elastic#76220)
  Test reverting "Add plugin status API (elastic#75819)" (elastic#76707)
  [Security Solution][Detections] Removes ML Job Settings SIEM copy and fixes link to ML app for creating custom jobs (elastic#76595)
  [Maps] remove region/coordinate-maps visualizations from sample data (elastic#76399)
  [DOCS] Dashboard-first docs refresh (elastic#76194)
  Updated ServiceNow description in docs and actions management UI to contains correct info (elastic#76344)
  [DOCS] Identifies cloud settings in reporting (elastic#76691)
  [Security Solution] Refactor timeline details to use search strategy (elastic#75591)
  es-archiver: Drop invalid index settings, support --query flag  (elastic#76522)
  [DOCS] Identifies graph settings available on cloud (elastic#76661)
  Add more info about a11y tests (elastic#76045)
  [data.search.SearchSource] Remove legacy ES client APIs. (elastic#75943)
  [release notes] automatically retry on Github API 5xx errors (elastic#76447)
  [es_ui_shared] Fix eslint exhaustive deps rule (elastic#76392)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Remove region/coordinate-maps visualizations from sample data in default distribution
4 participants