Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Performance enhancement for readRules function #76398

Closed
wants to merge 12 commits into from
Closed

[Security Solution][Detections] Performance enhancement for readRules function #76398

wants to merge 12 commits into from

Commits on Sep 17, 2020

  1. utlize schema.any() for validation on file in body of import rules re… 

    …quest, adds new functional tests and unit tests to make sure we can reach and don't go past bounds. These tests would have helped uncover performance issues io-ts gave us with validating the import rules file object
    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    4e4f286 View commit details
    Browse the repository at this point in the history

  2. fix type check failure

    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    c60fa32 View commit details
    Browse the repository at this point in the history

  3. updates getSimpleRule and getSimpleRuleAsNdjson to accept an enabled … 

    …param defaulted to false
    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    5697ee1 View commit details
    Browse the repository at this point in the history

  4. updates usage of readRules to utilize array of rule_ids

    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    3848487 View commit details
    Browse the repository at this point in the history

  5. allow readRules to look at the kibana alert id in patch rules route

    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    65ee86d View commit details
    Browse the repository at this point in the history

  6. general cleanup

    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    3e812b1 View commit details
    Browse the repository at this point in the history

  7. update chunk parse size from 50 to 100

    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    e9c0269 View commit details
    Browse the repository at this point in the history

  8. fixes comments

    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    6451153 View commit details
    Browse the repository at this point in the history

  9. fixes test

    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    2cf549e View commit details
    Browse the repository at this point in the history

  10. fixes FT test

    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    4331471 View commit details
    Browse the repository at this point in the history

  11. fix test data

    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    fb3d939 View commit details
    Browse the repository at this point in the history

  12. fixes from comments on pr

    @dhurley14
    dhurley14 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    377b543 View commit details
    Browse the repository at this point in the history