Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Read from metricbeat-* for ES node_stats #76015

Merged
merged 5 commits into from
Sep 8, 2020

Conversation

chrisronline
Copy link
Contributor

Relates to #73864

This PR adapts the UI code to read from metricbeat-* indices for queries against ES node_stats type monitoring documents while preserving existing functionality. This work is based off the changes done on the beats side (elastic/beats#19747) and must be used to test this PR. This PR should work outside of the beats PR, in that existing functionality shouldn't break at all (so it's safe to merge this to master without the beats PR going into master)

This is the first PR of several that will adapt the UI code to read from all monitoring document types, and as such, it comes with a little more code changes, mainly the changes necessary to ensure all queries start searching against metricbeat-* as well as handling the fact that type is not aliased.

To test:

  1. Clear all existing monitoring data (to make it easier to test, you don't need to do this)
  2. Pull down the beats feature branch
  3. Enable the elasticsearch-xpack module and start Metricbeat.
  4. Ensure you do not see node_stats in the response of this query:
POST .monitoring-es-*/_search
{
  "size": 0,
  "aggs": {
    "types": {
      "terms": {
        "field": "type",
        "size": 10
      }
    }
  }
}
  1. Ensure you at least see node_stats in the response to this query:
POST metricbeat-*/_search
{
  "size": 0,
  "aggs": {
    "types": {
      "terms": {
        "field": "metricset.name",
        "size": 20
      }
    }
  }
}
  1. Ensure the ES nodes list and ES node pages work properly

@chrisronline chrisronline requested a review from a team August 26, 2020 18:35
@chrisronline chrisronline self-assigned this Aug 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline chrisronline added the release_note:skip Skip the PR/issue when compiling release notes label Aug 26, 2020
@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected. Great job!

@chrisronline chrisronline merged commit d2ad7ce into elastic:master Sep 8, 2020
@chrisronline chrisronline deleted the monitoring/ecs_node_stats branch September 8, 2020 17:11
chrisronline added a commit that referenced this pull request Sep 8, 2020
* Read from metricbeat-* for node_stats

* Fix tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@chrisronline
Copy link
Contributor Author

Backport:

7.x: 8bde2b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants