Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] add message to empty add tooltip card #75809

Merged
merged 3 commits into from
Aug 25, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 24, 2020

This PR adds some empty state text to Tooltip field selector to highlight the functionallity enabled by adding tooltip fields. This was a recommendation from #75598 (review)

Screen Shot 2020-08-24 at 12 42 59 PM

@nreese nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.10.0 labels Aug 24, 2020
@nreese nreese requested a review from a team as a code owner August 24, 2020 18:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I expect in-app docs like this will really help with discoverability of features 🤞

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you don't need a title?

To create filters from field values, add a tooltip field.

Add field

@nreese
Copy link
Contributor Author

nreese commented Aug 25, 2020

Chatted offline with @gchaps and going to keep text as suggested by @thomasneirynck. Title is required so users know what the setting card refers too.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
maps 3.3MB +553.0B 3.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit e236bdf into elastic:master Aug 25, 2020
nreese added a commit to nreese/kibana that referenced this pull request Aug 25, 2020
* [Maps] add message to empty add tooltip card

* use suggested text
nreese added a commit that referenced this pull request Aug 25, 2020
* [Maps] add message to empty add tooltip card

* use suggested text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants