Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drilldowns] Beta badge support. Mark URL Drilldown as Beta #75654

Merged
merged 9 commits into from
Sep 18, 2020

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Aug 21, 2020

Summary

Part of: #69409

Team agreed that we'd like to release URL drilldown MVP as Beta.

Reasons for it:

  1. This issue lists outs caveats in current URL drilldown UX (dummy values in preview, too vague triggers, {{event.points}} hack). It might that improving those would require a breaking change in an API. We will do our best to handle changes with migrations, but there could be edge cases we won't be able to cover.
  2. We decided not to rush with extending url templating capabilities with more helpers. We could find out from early feedback that essential helpers are required. Even though this won't be breaking, worth mentioning here.
  3. Since URL drilldown is a new feature and relies on user's input, we might get early feedback that would required us for a significant changes in the feature. Make it Beta gives us more room for a pivot in this case.
  4. API Action concept might change how we reason about URL drilldown: [Drilldowns] Beta badge support. Mark URL Drilldown as Beta #75654 (review)

This pr adds support for isBeta property on drilldown definition, which displays beta badge in action wizard. I took copy from other place (I think from Lens).

Screenshot 2020-09-17 at 14 53 12
Screenshot 2020-09-17 at 14 53 03

This pr also marks URL drilldown as Beta.
I also updated URL drilldown docs to include default Beta warning:

Screenshot 2020-09-17 at 15 25 49

Checklist

Delete any items that are not applicable to this PR.

@Dosant Dosant added v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes Feature:Drilldowns Embeddable panel Drilldowns v7.10.0 labels Aug 21, 2020
@Dosant Dosant mentioned this pull request Aug 21, 2020
5 tasks
@streamich streamich mentioned this pull request Aug 21, 2020
24 tasks
@Dosant
Copy link
Contributor Author

Dosant commented Aug 24, 2020

@elasticmachine merge upstream

elasticmachine and others added 7 commits August 24, 2020 03:48
…s-beta-badge

# Conflicts:
#	x-pack/examples/ui_actions_enhanced_examples/public/dashboard_to_url_drilldown/index.tsx
#	x-pack/plugins/ui_actions_enhanced/public/components/action_wizard/action_wizard.tsx
#	x-pack/plugins/ui_actions_enhanced/public/components/action_wizard/i18n.ts
#	x-pack/plugins/ui_actions_enhanced/public/drilldowns/drilldown_definition.ts
#	x-pack/plugins/ui_actions_enhanced/public/dynamic_actions/action_factory_definition.ts
@Dosant Dosant changed the title [Drilldowns] Beta badge support [Drilldowns] Beta badge support. Mark URL Drilldown as Beta Sep 17, 2020
@Dosant Dosant marked this pull request as ready for review September 17, 2020 13:27
@Dosant Dosant requested a review from a team as a code owner September 17, 2020 13:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
embeddableEnhanced 40.1KB +49.0B 40.0KB
uiActionsEnhanced 379.5KB +1.2KB 378.3KB
total +1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link

@elastic-jb elastic-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this plan. I would like to get a little more thought into the API Action concept and make sure that we don't need to make adjustments for those scenarios that will require API changes.

Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@Dosant Dosant merged commit 827ee5c into elastic:master Sep 18, 2020
Dosant added a commit to Dosant/kibana that referenced this pull request Sep 18, 2020
…75654)

Team agreed that we'd like to release URL drilldown MVP as Beta.

Reasons for it:
1. Caveats in current URL drilldown UX (dummy values in preview, too vague triggers, {{event.points}} hack). It might that improving those would require a breaking change in an API. We will do our best to handle changes with migrations, but there could be edge cases we won't be able to cover.
2. We decided not to rush with extending url templating capabilities with more helpers. We could find out from early feedback that essential helpers are required. Even though this won't be breaking, worth mentioning here.
3. Since URL drilldown is a new feature and relies on user's input, we might get early feedback that would required us for a significant changes in the feature. Make it Beta gives us more room for a pivot in this case.
4. API Action concept might change how we reason about URL drilldown

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Dosant added a commit that referenced this pull request Sep 18, 2020
…77860)

Team agreed that we'd like to release URL drilldown MVP as Beta.

Reasons for it:
1. Caveats in current URL drilldown UX (dummy values in preview, too vague triggers, {{event.points}} hack). It might that improving those would require a breaking change in an API. We will do our best to handle changes with migrations, but there could be edge cases we won't be able to cover.
2. We decided not to rush with extending url templating capabilities with more helpers. We could find out from early feedback that essential helpers are required. Even though this won't be breaking, worth mentioning here.
3. Since URL drilldown is a new feature and relies on user's input, we might get early feedback that would required us for a significant changes in the feature. Make it Beta gives us more room for a pivot in this case.
4. API Action concept might change how we reason about URL drilldown

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 22, 2020
* master: (92 commits)
  [ILM] Data tiers for 7.10 (elastic#76126)
  [ML] Transforms: Fixes styling of preview grid pagination in summary step (elastic#77789)
  [Drilldowns] Beta badge support. Mark URL Drilldown as Beta (elastic#75654)
  Re-enable session lifespan, idle timeout api integration tests and use unique names for the security test reports. (elastic#77746)
  [Alerting] renames code in alerting RBAC exemption to make it easier to maintain (elastic#77598)
  [Alerting & Actions] Overwrite SOs when updating instead of partially updating (elastic#73688)
  fixed react warning in Suspense in alert flyout (elastic#77777)
  [APM] Track usage of Gold+ features (elastic#77630)
  Visualize: Bad request when working with histogram aggregation (elastic#77684)
  remove legacy ES plugin (elastic#77703)
  [Lens] change name of custom query to filters (elastic#77725)
  skip flaky suite (elastic#76239)
  remove visual aspects of baseline job (elastic#77815)
  skip flaky suite (elastic#77835)
  Fixes typo in data recognizer text (elastic#77691)
  management/update trusted_apps jest snapshot
  [build] Use Elastic hosted UBI minimal base image (elastic#77776)
  [APM] Add transaction error rate alert (elastic#76933)
  [Security Solution] [Detections] Remove file validation on import route (elastic#77770)
  [Enterprise Search][tech debt] Add Kea logic paths for easier debugging/defaults (elastic#77698)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Drilldowns Embeddable panel Drilldowns release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants