Migrate data folder creation from legacy to KP #75527

pgayvallet · 2020-08-20T07:48:41Z

Summary

Fix #73002

rename the uuid service to environment
move the data folder creation from the legacy kibana plugin to the renamed service

Checklist

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

…lder-creation

elasticmachine · 2020-08-20T12:38:37Z

Pinging @elastic/kibana-platform (Team:Platform)

mikecote

Alerting code LGTM

igoristic

Stack Monitoring side looks good 👍

…lder-creation

pgayvallet · 2020-08-21T13:06:46Z

@elastic/kibana-telemetry the telemetry schema check fails. probably because of the reintegration of the changes from #75536, as this PR also remove things from the last remaining legacy plugin.

Seems like

kibana/.telemetryrc.json

Lines 2 to 10 in 266f853

    
           { 
        
             "output": "src/plugins/telemetry/schema/legacy_oss_plugins.json", 
        
             "root": "src/legacy/core_plugins/", 
        
             "exclude": [ 
        
               "src/legacy/core_plugins/testbed", 
        
               "src/legacy/core_plugins/elasticsearch", 
        
               "src/legacy/core_plugins/tests_bundle" 
        
             ] 
        
           },

is no longer extracting anything:

ERROR Error: No paths covered from /dev/shm/workspace/parallel/13/kibana/src/legacy/core_plugins/ by the .telemetryrc.json

should I just remove the legacy_oss_plugins.json entry from .telemetryrc.json, or is there anything else/more to do here?

afharo · 2020-08-21T13:45:32Z

should I just remove the legacy_oss_plugins.json entry from .telemetryrc.json, or is there anything else/more to do here?

@pgayvallet I think we are safe to remove that entry completely 👍

…lder-creation

mshustov · 2020-08-26T08:13:57Z

src/core/server/server.api.md

@@ -752,6 +752,11 @@ export interface EnvironmentMode {
    prod: boolean;
 }

+// @public
+export interface EnvironmentServiceSetup {
+    getInstanceUuid(): string;


as we are here: why it's exposed as a function? the value is static

mshustov · 2020-08-26T08:33:33Z

x-pack/plugins/task_manager/server/plugin.ts

@@ -42,7 +42,7 @@ export class TaskManagerPlugin
      .toPromise();

    setupSavedObjects(core.savedObjects, this.config);
-    this.taskManagerId = core.uuid.getInstanceUuid();
+    this.taskManagerId = core.environment.getInstanceUuid();


IMO it's confusing that environment service doesn't create Env public interface

kibana/src/core/server/core_context.ts

Line 33 in 85c8232

env: Env;

What if we make this service internal and pass uuid as a static value to the plugin constructor

kibana/src/core/server/plugins/plugin.ts

Line 171 in fa93a81

const instance = initializer(this.initializerContext);

?

I understand that it's not required for the issue you are working on, so we can rollback all the changes to the uuid service.

…lder-creation

pgayvallet

@restrry Moved instanceUuid to PluginInitializerContext. PTAL

pgayvallet · 2020-08-26T10:44:23Z

src/core/server/plugins/plugin_context.ts

+export interface InstanceInfo {
+  uuid: string;
+}


Added a structure as the pid will also be added here once we migrate it from the legacy server

pgayvallet · 2020-08-26T10:46:34Z

src/core/server/plugins/plugins_service.ts

-  public async discover() {
+  public async discover({ environment }: PluginsServiceDiscoverDeps) {


So, coreContext is created synchronously inside the Server constructor. Injecting the uuid inside it was way too heavy changes, as it would require to wait for the uuid service to setup (which itself requires the core context...). I'm now setuping the environment service before the call to plugins.discover and pass the setup contract to it to allow to access the uuid (and later, the pid)

pgayvallet · 2020-08-26T10:47:23Z

src/core/server/plugins/types.ts

  env: {
    mode: EnvironmentMode;
    packageInfo: Readonly<PackageInfo>;
+    instanceUuid: string;


instanceUuid is now accessible via pluginInitializerContext.env.instanceUuid, and the Environment service is no longer public.

mshustov · 2020-08-26T11:50:24Z

@pgayvallet LGTM

…lder-creation

kibanamachine · 2020-08-26T19:27:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 9522fa1

Build metrics

oss distributable file count

id	value	diff	baseline
total	26356	+1	26355

distributable file count

id	value	diff	baseline
total	53198	+1	53197

History

💔 Build #70461 failed 81e8708
💚 Build #69904 succeeded 6275b7e
💚 Build #69698 succeeded a57a7eb
💔 Build #69665 failed 6978fc4
💔 Build #69601 failed 3aa9a66

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* rename uuid service to environment service * adapt resolve_uuid to directly use the configurations * move data folder creation to core * update generated doc * fix types * fix monitoring tests * move instanceUuid to plugin initializer context * update generated doc

pgayvallet added 4 commits August 20, 2020 09:47

rename uuid service to environment service

9cf8086

adapt resolve_uuid to directly use the configurations

e7337cd

move data folder creation to core

3aba46e

update generated doc

2c3cbbf

pgayvallet added release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0 Feature:Legacy Removal Issues related to removing legacy Kibana labels Aug 20, 2020

pgayvallet added 2 commits August 20, 2020 11:33

fix types

57c2d69

Merge remote-tracking branch 'upstream/master' into kbn-73002-data-fo…

41469b0

…lder-creation

pgayvallet marked this pull request as ready for review August 20, 2020 12:38

pgayvallet requested review from a team as code owners August 20, 2020 12:38

pgayvallet requested a review from a team August 20, 2020 12:38

mikecote approved these changes Aug 20, 2020

View reviewed changes

igoristic approved these changes Aug 20, 2020

View reviewed changes

pgayvallet added 3 commits August 21, 2020 09:27

Merge remote-tracking branch 'upstream/master' into kbn-73002-data-fo…

3aa9a66

…lder-creation

fix monitoring tests

0b13ed9

Merge remote-tracking branch 'upstream/master' into kbn-73002-data-fo…

6978fc4

…lder-creation

pgayvallet added 2 commits August 21, 2020 16:33

Merge remote-tracking branch 'upstream/master' into kbn-73002-data-fo…

a57a7eb

…lder-creation

Merge remote-tracking branch 'upstream/master' into kbn-73002-data-fo…

6275b7e

…lder-creation

mshustov approved these changes Aug 26, 2020

View reviewed changes

pgayvallet added 3 commits August 26, 2020 12:25

move instanceUuid to plugin initializer context

3e3a4db

update generated doc

fb9618b

Merge remote-tracking branch 'upstream/master' into kbn-73002-data-fo…

81e8708

…lder-creation

pgayvallet commented Aug 26, 2020

View reviewed changes

pgayvallet requested a review from mshustov August 26, 2020 10:52

Merge remote-tracking branch 'upstream/master' into kbn-73002-data-fo…

9522fa1

…lder-creation

pgayvallet merged commit eee1392 into elastic:master Aug 26, 2020

pgayvallet mentioned this pull request Aug 26, 2020

[7.x] Migrate data folder creation from legacy to KP (#75527) #76025

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate data folder creation from legacy to KP #75527

Migrate data folder creation from legacy to KP #75527

pgayvallet commented Aug 20, 2020 •

edited

Loading

elasticmachine commented Aug 20, 2020

mikecote left a comment

igoristic left a comment

pgayvallet commented Aug 21, 2020

afharo commented Aug 21, 2020

mshustov Aug 26, 2020

mshustov Aug 26, 2020

pgayvallet left a comment

pgayvallet Aug 26, 2020

pgayvallet Aug 26, 2020

pgayvallet Aug 26, 2020

mshustov commented Aug 26, 2020

kibanamachine commented Aug 26, 2020

		public async discover() {
		public async discover({ environment }: PluginsServiceDiscoverDeps) {

Migrate data folder creation from legacy to KP #75527

Migrate data folder creation from legacy to KP #75527

Conversation

pgayvallet commented Aug 20, 2020 • edited Loading

Summary

Checklist

elasticmachine commented Aug 20, 2020

mikecote left a comment

Choose a reason for hiding this comment

igoristic left a comment

Choose a reason for hiding this comment

pgayvallet commented Aug 21, 2020

afharo commented Aug 21, 2020

mshustov Aug 26, 2020

Choose a reason for hiding this comment

mshustov Aug 26, 2020

Choose a reason for hiding this comment

pgayvallet left a comment

Choose a reason for hiding this comment

pgayvallet Aug 26, 2020

Choose a reason for hiding this comment

pgayvallet Aug 26, 2020

Choose a reason for hiding this comment

pgayvallet Aug 26, 2020

Choose a reason for hiding this comment

mshustov commented Aug 26, 2020

kibanamachine commented Aug 26, 2020

💚 Build Succeeded

Build metrics

oss distributable file count

distributable file count

History

pgayvallet commented Aug 20, 2020 •

edited

Loading