add client-side feature usage API #75486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
release_note:skip
|
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
changed the title
…side-feature-usage
…side-feature-usage
mshustov
approved these changes
Aug 26, 2020
| }, | ||
| }, | ||
| async (context, request, response) => { | ||
| const [, , { featureUsage }] = await getStartServices(); |
There was a problem hiding this comment.
optional: why not use context to pass the start contract?
| return { | ||
| notifyUsage: async (featureName, usedAt = Date.now()) => { | ||
| const lastUsed = isDate(usedAt) ? usedAt.getTime() : usedAt; | ||
| await http.post('/internal/licensing/feature_usage/notify', { |
There was a problem hiding this comment.
in theory, we can overload the server-side if notifyUsage is called frequently. But it might be premature optimization.
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
page load bundle size
distributable file count
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Aug 31, 2020
* add client-side feature_usage API * use route context for notify feature usage route
pgayvallet
added a commit
that referenced
this pull request
Aug 31, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 31, 2020
…s-for-710 * 'master' of github.com:elastic/kibana: (43 commits) [APM] Chart units don't update when toggling the chart legends (elastic#74931) [ILM] Add support for frozen phase in UI (elastic#75968) Hides advanced json for count metric (elastic#74636) add client-side feature usage API (elastic#75486) [Maps] add drilldown support map embeddable (elastic#75598) [Enterprise Search] Request handler refactors/enhancements + update existing routes to use shared handler (elastic#76106) [Resolver] model `location.search` in redux (elastic#76140) [APM] Prevent imports of public in server code (elastic#75979) fix eslint issue skip flaky suite (elastic#76223) [APM] Transaction duration anomaly alerting integration (elastic#75719) [Transforms] Avoid using "Are you sure" (elastic#75932) [Security Solution][Exceptions] - Fix bug of alerts not updating after closure from exceptions modal (elastic#76145) [plugin-helpers] improve 3rd party KP plugin support (elastic#75019) [docs/getting-started] link to yarn v1 specifically (elastic#76169) [Security_Solution][Resolver] Resolver loading and error state (elastic#75600) Fixes App Search documentation links (elastic#76133) Fix alerts unable to create / update when the name has trailing whitepace(s) (elastic#76079) [Resolver] Fix useSelector usage (elastic#76129) [Enterprise Search] Migrate util and components from ent-search (elastic#76051) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/data_tier_allocation/node_allocation.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/services/policies/types.ts # x-pack/plugins/index_lifecycle_management/public/application/services/policies/warm_phase.ts
Dosant
reviewed
Aug 31, 2020
| return { | ||
| notifyUsage: async (featureName, usedAt = Date.now()) => { | ||
| const lastUsed = isDate(usedAt) ? usedAt.getTime() : usedAt; | ||
| await http.post('/internal/licensing/feature_usage/notify', { |
There was a problem hiding this comment.
@pgayvallet, should we catch and swallow errors here? I guess consumer shouldn't care about handling errors from this (nor probably wait for a success) and unhandled promise rejection from this call would be a bummer.
There was a problem hiding this comment.
idk. Realistically, the only reason this would fails (appart from network failures) would be if the consumer tries to notify usage of an unregistered feature, which it a consumer cause (and should be detected in development).
Also, unhandled rejections on the client-side don't really do much (even if of course they should be avoided)
But that's not a strong opinion, and if really you think this is preferable, I can change that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #72572
Add client-side version of the
featureUsageAPI to the licensing pluginChecklist