[Reporting/JobListing] fix user ID for non-security in queries #75365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
changed the title
tsullivan
force-pushed
the
reporting/revert-createdby-nosecurity
branch
2 times, most recently
from
75eebb3
to
374947d
Compare
tsullivan
force-pushed
the
reporting/revert-createdby-nosecurity
branch
from
374947d
to
1e0a49f
Compare
tsullivan
commented
Aug 18, 2020
tsullivan
commented
Aug 18, 2020
tsullivan
commented
Aug 18, 2020
tsullivan
added
release_note:skip
joelgriffith
approved these changes
Aug 19, 2020
|
Thanks for adding functional tests, very helpful! |
tsullivan
force-pushed
the
reporting/revert-createdby-nosecurity
branch
from
c6225a0
to
eea3153
Compare
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
|
Head's up for @joelgriffith I have backed out the Typescript changes made in the jobs_query module, as that created a lot of questions that we can move to another PR. |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Aug 19, 2020
…ic#75365) * [Reporting/JobListing] fix user ID for non-security in queries * fix tests * add fn api test * fix ci * revert TS exploration # Conflicts: # x-pack/scripts/functional_tests.js # x-pack/test/reporting_api_integration/reporting_and_security/bwc_existing_indexes.ts # x-pack/test/reporting_api_integration/reporting_and_security/bwc_generation_urls.ts
tsullivan
added a commit
that referenced
this pull request
Aug 21, 2020
…75365) (#75496) * [Reporting/JobListing] fix user ID for non-security in queries (#75365) * [Reporting/JobListing] fix user ID for non-security in queries * fix tests * add fn api test * fix ci * revert TS exploration # Conflicts: # x-pack/scripts/functional_tests.js # x-pack/test/reporting_api_integration/reporting_and_security/bwc_existing_indexes.ts # x-pack/test/reporting_api_integration/reporting_and_security/bwc_generation_urls.ts * fix bad merge Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #75239
Caused by #74915 which unintentionally added a breaking change in the Reporting document in Elasticsearch.
Refactoring and revising Typescript broke the value type that was actually being indexed in Elasticsearch, which broke the listing searches for users with security disabled.
Changes:
ReportingUsertypestring | nullvalue types back tostring | falsefor thecreated_byfieldserver/routes/lib/jobs_query.tsto remove custom types and use imported onesChecklist
Delete any items that are not applicable to this PR.
[ ] TODO: confirm https://github.com/elastic/kibana/pull/75365/files#r472557510[ ] Add more_source_excludeFor maintainers