-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing Reactive Issue With Vis By Value #75222
Closed
ThomThomson
wants to merge
30
commits into
elastic:master
from
ThomThomson:testing/ReactiveIssueWithByValueVis
Closed
Testing Reactive Issue With Vis By Value #75222
ThomThomson
wants to merge
30
commits into
elastic:master
from
ThomThomson:testing/ReactiveIssueWithByValueVis
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing broken behavior and applying relevant changes Adding changes to dashboard Removing unnecessary empty line Removing unnecessary deepClone Fixing some stuff in dashboard container Extracting logic into common components Fixing eslint Fix breadcrumbs Fixing error in search interceptor Reintroduce mistakenly removed empty lines Renaming function
…nel-input-updates
…ana into fix/embeddable-panel-input-updates
…ity for by value embeddables
ThomThomson
added
Feature:Embedding
Embedding content via iFrame
release_note:skip
Skip the PR/issue when compiling release notes
labels
Aug 17, 2020
💔 Build Failed
Failed CI StepsTest FailuresChrome UI Functional Tests.test/functional/apps/dashboard/empty_dashboard·js.dashboard app using current data empty dashboard should add new visualization from dashboardStandard Out
Stack Trace
Chrome UI Functional Tests.test/functional/apps/dashboard/empty_dashboard·js.dashboard app using current data empty dashboard should add new visualization from dashboardStandard Out
Stack Trace
Chrome UI Functional Tests.test/functional/apps/dashboard/view_edit·js.dashboard app using current data dashboard view edit mode shows lose changes warning and loses changes on confirmation when a new vis is addedStandard Out
Stack Trace
Build metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Embedding
Embedding content via iFrame
release_note:skip
Skip the PR/issue when compiling release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is an easy way to share a merge between #74253 and #72256 that illustrates how the reactivity issue still persists on 'by value' embeddables.