Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix setting the initial Kibana filters #75215

Merged
merged 10 commits into from
Aug 24, 2020
Merged

[Security Solution] Fix setting the initial Kibana filters #75215

merged 10 commits into from
Aug 24, 2020

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Aug 17, 2020 •
edited by stephmilovic
Loading

Summary

Fixes #75142

Checklist

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience release_note:fix Team:SIEM v8.0.0 v7.10.0 v7.9.1 labels Aug 17, 2020
@patrykkopycinski patrykkopycinski self-assigned this Aug 17, 2020
@patrykkopycinski patrykkopycinski marked this pull request as ready for review August 17, 2020 21:48
@patrykkopycinski patrykkopycinski requested review from a team as code owners August 17, 2020 21:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@patrykkopycinski patrykkopycinski requested a review from a team as a code owner August 18, 2020 09:00
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

1 similar comment
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

stephmilovic
stephmilovic approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and manual testing all LGTM. I feel like the eslint-disable-next-line react-hooks/exhaustive-deps in security_solution code is often indicative of a bug...

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.2MB +914.0B 7.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 65c7248 into elastic:master Aug 24, 2020
@patrykkopycinski patrykkopycinski deleted the fix/siem-initial-kibana-search-filters branch August 24, 2020 13:25
@patrykkopycinski patrykkopycinski mentioned this pull request Aug 24, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Aug 24, 2020
@patrykkopycinski @elasticmachine
[Security Solution] Fix setting the initial Kibana filters (elastic#7…
c53c630 
…5215)

* [Security Solution] Fix setting the initial Kibana filters

* add unit test

* keep appState in kibana storage

* fix logic

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@patrykkopycinski patrykkopycinski mentioned this pull request Aug 24, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Aug 24, 2020
@patrykkopycinski @elasticmachine
[Security Solution] Fix setting the initial Kibana filters (elastic#7…
bd30c8b 
…5215)

* [Security Solution] Fix setting the initial Kibana filters

* add unit test

* keep appState in kibana storage

* fix logic

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
patrykkopycinski added a commit that referenced this pull request Aug 24, 2020
@patrykkopycinski @elasticmachine
[Security Solution] Fix setting the initial Kibana filters (#75215) (#…
8e8bb4a 
…75752)

* [Security Solution] Fix setting the initial Kibana filters

* add unit test

* keep appState in kibana storage

* fix logic

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
patrykkopycinski added a commit that referenced this pull request Aug 24, 2020
@patrykkopycinski @elasticmachine
[Security Solution] Fix setting the initial Kibana filters (#75215) (#…
0743648 
…75751)

* [Security Solution] Fix setting the initial Kibana filters

* add unit test

* keep appState in kibana storage

* fix logic

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@MadameSheema MadameSheema MadameSheema approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.1 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Filter applied in Discover app displayed on the Security app
7 participants
@patrykkopycinski @elasticmachine @kibanamachine @lukeelmers @stephmilovic @MadameSheema @MindyRS