Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] fix removing ingest pipelines from elasticsearch #75092

Merged
merged 2 commits into from
Aug 15, 2020

Conversation

neptunian
Copy link
Contributor

@neptunian neptunian commented Aug 14, 2020

Fixes bug where non entry ingest pipelines were not being deleted from elasticsearch when package was removed or there was a pipeline removal between updates. Since no packages seem to be using non entry pipelines at the moment it should not be an issue currently.

Changes

  • deletes each pipeline based on the id in the saved object package installation, ensuring each pipeline is deleted
  • adds integration test that the right pipelines were removed during an install and an update, including non entry pipelines

@neptunian neptunian added v8.0.0 v7.10.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 14, 2020
@neptunian neptunian requested a review from a team August 14, 2020 21:22
@neptunian neptunian self-assigned this Aug 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@neptunian neptunian merged commit 46a268f into elastic:master Aug 15, 2020
neptunian added a commit to neptunian/kibana that referenced this pull request Aug 15, 2020
…astic#75092)

* fix removing ingest pipelines bug

* undo unneeded changes to default.yml entry pipeline
neptunian added a commit that referenced this pull request Aug 15, 2020
…5092) (#75122)

* fix removing ingest pipelines bug

* undo unneeded changes to default.yml entry pipeline
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 17, 2020
* master: (24 commits)
  [ML] Functional tests - skip regression and classification tests
  [Ingest Manager] fix removing ingest pipelines from elasticsearch (elastic#75092)
  move tests for placeholder indices to setup (elastic#75096)
  [jest] temporarily extend default test timeout (elastic#75118)
  [cli] remove reference to removed --optimize flag (elastic#75083)
  skip flaky suite (elastic#75044)
  Adding /etc/rc.d/init.d/functions to the init script when present to … (elastic#22985)
  [jenkins] add pipeline for hourly security solution cypress tests (elastic#75087)
  [Reporting/Flaky Test] Skip test for paging list of reports (elastic#75075)
  remove .kbn-optimizer-cache upload (elastic#75086)
  skip flaky suite (elastic#74814)
  Actions add proxy support (elastic#74289)
  [ILM] TS conversion of Edit policy components (elastic#74747)
  [Resolver] simulator tests select elements directly instead of using descendant selectors. (elastic#75058)
  [Enterprise Search] Add Workplace Search side navigation (elastic#74894)
  [Security solution] Sourcerer: Kibana index pattern selector for security views (elastic#74706)
  [Logs UI] Remove apollo deps from log link-to routes (elastic#74502)
  [Maps] add map configurations to docker list (elastic#75035)
  [functional test][saved objects] update tests for additional copy saved objects to space (elastic#74907)
  Make the alerts plugin support generics (elastic#72716)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants