Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting/Functional] unskip pagination test #74973

Merged
merged 3 commits into from
Aug 13, 2020

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Aug 13, 2020

Summary

Closes #74922

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@@ -4,9 +4,7 @@
* you may not use this file except in compliance with the Elastic License.
*/

import { FtrProviderContext } from '../../ftr_provider_context';

export default ({ loadTestFile }: FtrProviderContext) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to JS file so that it can run in the flaky test runner

@tsullivan tsullivan marked this pull request as ready for review August 13, 2020 19:37
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0 labels Aug 13, 2020
@tsullivan
Copy link
Member Author

Update: This branch has just passed in the flaky test runner 15 times.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
reporting 291.0KB -33.0B 291.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@rashmivkulkarni rashmivkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ,

  • test is successful multiple times on FTR.
  • code reviewed.
  • also like the fact that findbyCssSelector is replaced by actual id of the object.

@tsullivan tsullivan merged commit 447854d into elastic:master Aug 13, 2020
@tsullivan tsullivan deleted the reporting/unskip-paging-fntest branch August 13, 2020 22:08
tsullivan added a commit to tsullivan/kibana that referenced this pull request Aug 14, 2020
* [Reporting/Functional] unskip pagination test

* change to js file for flaky test runner

* fix ts
tsullivan added a commit that referenced this pull request Aug 14, 2020
* [Reporting/Functional] unskip pagination test

* change to js file for flaky test runner

* fix ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 14, 2020
* master: (23 commits)
  Adding API test for custom link transaction example (elastic#74238)
  [Uptime] Singular alert (elastic#74659)
  Revert "attempt excluding a codeowners directory" (elastic#75023)
  [Metrics UI] Remove TSVB dependency from Metrics Explorer APIs (elastic#74804)
  Remove degraded state from ES status service (elastic#75007)
  [Reporting/Functional] unskip pagination test (elastic#74973)
  [Resolver] Stale query string values are removed when resolver's component instance ID changes. (elastic#74979)
  Add public url to Workplace Search plugin (elastic#74991)
  [Reporting] Update more Server Types for TaskManager (elastic#74915)
  [I18n] verify select icu-message options are in english (elastic#74963)
  Make data.search.aggs available on the server. (elastic#74472)
  [Security Solution][Resolver] Graph Control Tests and Update Simulator Selectors (elastic#74680)
  attempt excluding a codeowners directory
  [ML] DF Analytics: allow failed job to be stopped by force via the UI (elastic#74710)
  Add kibana-core-ui-designers team (elastic#74970)
  [Metrics UI] Fix inventory footer misalignment (elastic#74707)
  Remove legacy optimizer (elastic#73154)
  Update design-specific GH code-owners (elastic#74877)
  skip test Reporting paginates content elastic#74922
  [Metrics UI] Add Jest tests for alert previews (elastic#74890)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
3 participants