Commits on Aug 12, 2020

1. [Enterprise Search] Add solution-level side navigation (elastic#74705) …

   * Add basic layout/sidebar blocking
   
   - note: we should *not* set left: 0 / top: 0 etc., as this can interfere with Kibana's existing UI (e.g. docked navigation, telemetry callout)
   
   * Add sidebar styles + static links
   
   * Refactor SideNav to be a reusable component
   
   - So that Workplace Search can reuse the same layout but pass in their own custom nav
   + Refactor AppSearch to use Layout in router
   
   * Refactor all views to account for in-router Layout
   
   * Fix root redirects not working as expected
   
   - If enterpriseSearchUrl hasn't been set, all pages should redirect to SetupGuide, not just root
   - The engines redirect simply wasn't working at all - it would always show a blank page when '/' was clicked in the Kibana breadcrumbs. Not sure if this is a Kibana issue - had to change to a component load to fix
   + Simplify index.test.tsx (probably unreasonable and not super helpful to add assertions for each new route)
   
   * Implement active styling for links
   
   * Fix failing location tests
   
   - By adding a new useLocation mock
   + add SideNavLink active class test
   
   TODO: I should probably rename react_router_history.mock to just react_router.mock
   
   * Add responsive toggle + styling
   
   * Add navigation accessibility attributes/controls
   
   * [Feedback] Update mobile UX to close menu on link click/navigation
   
   - This requires updating our EUI/React Router components to accept and run custom onClick events
   - Also requires adding a new ReactContext to pass down closeNavigation, but that's not too onerous thanks to useContext

   

   Constance authored and cee-chen committed Aug 12, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 8fd103e
   • Browse repository at this point

   Copy the full SHA

   8fd103e View commit details

   Browse the repository at this point in the history