Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - stabilize DFA dependent variable input #74829

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Aug 12, 2020

Summary

This PR stabilizes the dependent variable input during tests by explicitly waiting for the options to load.

Closes #74447

@pheyos pheyos requested a review from a team as a code owner August 12, 2020 07:34
@pheyos pheyos self-assigned this Aug 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member Author

pheyos commented Aug 12, 2020

Checking test stability in a flaky test runner job ... => no failure in 50 runs ✔️

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ml 7.9MB +100.0B 7.9MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos merged commit 178afd7 into elastic:master Aug 12, 2020
@pheyos pheyos deleted the stabilize_dependent_variable_input branch August 12, 2020 11:42
pheyos added a commit to pheyos/kibana that referenced this pull request Aug 12, 2020
…ic#74829)

This PR stabilizes the dependent variable input during tests by explicitly waiting for the options to load.
pheyos added a commit to pheyos/kibana that referenced this pull request Aug 12, 2020
…ic#74829)

This PR stabilizes the dependent variable input during tests by explicitly waiting for the options to load.
pheyos added a commit that referenced this pull request Aug 12, 2020
… (#74846)

This PR stabilizes the dependent variable input during tests by explicitly waiting for the options to load.
pheyos added a commit that referenced this pull request Aug 12, 2020
… (#74845)

This PR stabilizes the dependent variable input during tests by explicitly waiting for the options to load.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants