Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Add solution-level side navigation #74705

Merged
merged 10 commits into from
Aug 12, 2020
Merged

[Enterprise Search] Add solution-level side navigation #74705

merged 10 commits into from
Aug 12, 2020

Commits on Aug 11, 2020

  1. Add basic layout/sidebar blocking 

    - note: we should *not* set left: 0 / top: 0 etc., as this can interfere with Kibana's existing UI (e.g. docked navigation, telemetry callout)
    @cee-chen
    cee-chen committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4f6cb95 View commit details
    Browse the repository at this point in the history

  2. Add sidebar styles + static links

    @cee-chen
    cee-chen committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    b9b38ad View commit details
    Browse the repository at this point in the history

  3. Refactor SideNav to be a reusable component 

    - So that Workplace Search can reuse the same layout but pass in their own custom nav
+ Refactor AppSearch to use Layout in router
    @cee-chen
    cee-chen committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    cee4072 View commit details
    Browse the repository at this point in the history

  4. Refactor all views to account for in-router Layout

    @cee-chen
    cee-chen committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    dd5ec40 View commit details
    Browse the repository at this point in the history

  5. Fix root redirects not working as expected 

    - If enterpriseSearchUrl hasn't been set, all pages should redirect to SetupGuide, not just root
- The engines redirect simply wasn't working at all - it would always show a blank page when '/' was clicked in the Kibana breadcrumbs. Not sure if this is a Kibana issue - had to change to a component load to fix
+ Simplify index.test.tsx (probably unreasonable and not super helpful to add assertions for each new route)
    @cee-chen
    cee-chen committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4743611 View commit details
    Browse the repository at this point in the history

  6. Implement active styling for links

    @cee-chen
    cee-chen committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    f1206c2 View commit details
    Browse the repository at this point in the history

  7. Fix failing location tests 

    - By adding a new useLocation mock
+ add SideNavLink active class test

TODO: I should probably rename react_router_history.mock to just react_router.mock
    @cee-chen
    cee-chen committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    c3e6cc1 View commit details
    Browse the repository at this point in the history

  8. Add responsive toggle + styling

    @cee-chen
    cee-chen committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    3a5e7fb View commit details
    Browse the repository at this point in the history

  9. Add navigation accessibility attributes/controls

    @cee-chen
    cee-chen committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    9f371ad View commit details
    Browse the repository at this point in the history

  10. [Feedback] Update mobile UX to close menu on link click/navigation 

    - This requires updating our EUI/React Router components to accept and run custom onClick events
- Also requires adding a new ReactContext to pass down closeNavigation, but that's not too onerous thanks to useContext
    @cee-chen
    cee-chen committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    e63d2b2 View commit details
    Browse the repository at this point in the history