Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timelion app deprecation warning #74660

Merged
merged 10 commits into from
Aug 18, 2020

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Aug 10, 2020

Summary

Closes #63012.
Adds a warning on Timelion app to notify the users that Timelion app is going to be removed on 8.0+ and adds a link to the documentation on how to move the existing worksheets to a dashboard. The documentation has been covered here.

Screenshot 2020-08-12 at 9 11 22 AM

Screenshot 2020-08-12 at 9 11 33 AM

Checklist

Delete any items that are not applicable to this PR.

@stratoula stratoula marked this pull request as ready for review August 12, 2020 08:16
@stratoula stratoula requested a review from a team as a code owner August 12, 2020 08:16
@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Aug 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula requested review from a team and gchaps August 12, 2020 08:17
@stratoula
Copy link
Contributor Author

@gchaps I need your feedback for the message. 😄
Deprecated since 7.0, Timelion app will be removed in 8.0. To move your existing worksheets to a dashboard click here

@gchaps
Copy link
Contributor

gchaps commented Aug 12, 2020

@stratoula Here is my suggestion

Deprecated since 7.0, the Timelion app will be removed in 8.0. To continue using your Timelion worksheets, migrate them to a dashboard.

Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform changes LGTM

@stratoula
Copy link
Contributor Author

@gchaps thank you a ton!

@stratoula stratoula requested a review from timroes August 13, 2020 12:09
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
timelion 107 +2 105

async chunks size

id value diff baseline
timelion 593.2KB +1.7KB 591.5KB

page load bundle size

id value diff baseline
core 1.2MB +244.0B 1.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 198806b into elastic:master Aug 18, 2020
stratoula added a commit to stratoula/kibana that referenced this pull request Aug 18, 2020
* wip deprecation notice on timelion app

* Add a deprecation notice on timelion app

* Minor, add visualize and timelion on the docLinks

* Chage the layout a bit

* Change the deprecation notice message

* Change the deprecation notice message

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
stratoula added a commit that referenced this pull request Aug 18, 2020
* wip deprecation notice on timelion app

* Add a deprecation notice on timelion app

* Minor, add visualize and timelion on the docLinks

* Chage the layout a bit

* Change the deprecation notice message

* Change the deprecation notice message

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@KOTungseth KOTungseth mentioned this pull request Oct 14, 2020
1 task
@stratoula stratoula mentioned this pull request Sep 9, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Timelion Timelion app and visualization release_note:deprecation Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deprecation notice to Timelion app
6 participants