Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[telemetry] update README to downplay ui_metrics #74635

Merged
merged 2 commits into from
Aug 11, 2020
Merged

[telemetry] update README to downplay ui_metrics #74635

merged 2 commits into from
Aug 11, 2020

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Aug 10, 2020

downplays ui_metrics in docs

Closes #65776

CC @alexfrancoeur

@Bamieh Bamieh added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:KibanaTelemetry v7.10.0 labels Aug 10, 2020
@Bamieh Bamieh requested a review from a team as a code owner August 10, 2020 08:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@Bamieh
Copy link
Member Author

Bamieh commented Aug 10, 2020

@elasticmachine merge upstream

afharo
afharo approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@afharo afharo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

NIT: I'd personally get UI Metrics fixed to make it useful rather than downplaying it because it will create lots of usage collectors that could be solved with UI Metrics and discouraging it being used to later change the message can create confusion among other teams (especially when we are planning to fix it for 7.10?)

@Bamieh
Copy link
Member Author

Bamieh commented Aug 10, 2020

@afharo Yes hopefully we'll have a working implementation in 7.10. In the meantime adding this messaging makes it clearer for devs who are interested in using ui_metrics to not use it.

@afharo
Copy link
Member

afharo commented Aug 10, 2020

@Bamieh that's my question then: Why should we update the documentation that we'll backport to 7.10 to remove it again before 7.10 FF and, in the meantime, devs developing new telemetry (aimed for 7.10+ at this stage) will be encouraged to do workarounds (when, for 7.10, it'll be totally fine for them to use it)?

Maybe I'm missing something: I'm thinking we don't plan to change the APIs, only the internals (so it's transparent for the devs). If so, I don't think we should bother spreading the word to NOT use it at this stage because, by 7.10 FF, they'll be OK to use it (and nothing will change on their end?).

But you've been digging in this issue longer than I do. So I'll follow your lead on this 🙂

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexfrancoeur
Copy link

Let's discuss during the sync today. If changes are coming to make ui_metrics usable, then maybe we don't need to downplay them anymore. The details are still a bit hazy to me on the plan here though.

TinaHeiligers
TinaHeiligers approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bamieh Bamieh merged commit 53828da into elastic:master Aug 11, 2020
@Bamieh Bamieh deleted the telemetry/docs_ui_metrics branch August 11, 2020 12:24
@Bamieh Bamieh mentioned this pull request Aug 11, 2020
Merged
Bamieh added a commit that referenced this pull request Aug 11, 2020
@Bamieh @elasticmachine
[7.x] [telemetry] update README to downplay ui_metrics (#74635) (#74753)
69e5afe 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 11, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
1dbf2f2 
* master: (106 commits)
  [Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (elastic#74736)
  [Lens] Add styling options for x and y axes on the settings popover (elastic#71829)
  [Maps] add initial location option that fits to data bounds (elastic#74583)
  theme function (elastic#73451)
  [data.ui.query] Write filters to query log from default editor. (elastic#74474)
  [data.search.SearchSource] Move some SearchSource dependencies to the server. (elastic#74607)
  [Canvas][tech-debt] Convert renderers (elastic#74134)
  [security solutions][lists] Adds end to end tests (elastic#74473)
  pluralized for occurrences vs occurrence (elastic#74564)
  Update links that pointed to CONTRIBUTING.md (elastic#74757)
  [Ingest pipelines] Implement tabs in processor flyout (elastic#74469)
  [Event log] Use Alerts client & Actions client when fetching these types of SOs (elastic#73257)
  Bump chalk to 4.1.0 (elastic#73397)
  Index pattern field list - transition away from extending array - introduce and use getAll() (elastic#74718)
  [SECURITY] Bugs css/inspect (elastic#74711)
  [telemetry] update README to downplay ui_metrics (elastic#74635)
  Fixed grammar (elastic#74725)
  [Telemetry][API Integration] size_in_bytes to be a number (elastic#74664)
  [ILM] Convert node details flyout to TS (elastic#73707)
  [Ingest Node Pipelines] Sentence-case processor names (elastic#74645)
  ...
@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove or downplay ui_metrics in usage collection README
7 participants
@Bamieh @elasticmachine @afharo @kibanamachine @alexfrancoeur @TinaHeiligers @lukeelmers