Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC map embeddable drilldown support #74346

Closed
wants to merge 1 commit into from

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Aug 5, 2020

Summary

Addresses #67567
This is possible because of change in #71468. Now dashboard drilldown relies on higher lever "apply_filter_trigger" instead of "value_click" and "range_select" which today more visualise specific.

We could disable drilldown support for shape filters if current UX doesn't make sense following approach exposed in: https://github.com/elastic/kibana/pull/73067/files#diff-5e1b409189846a80d497b0ebc8c1c440R252

Kapture 2020-08-05 at 12 02 54


I guess next steps would be for maps team to take this over and finalise (disabling in some places if needed, docs, function test) in scope of #67567 according to priorities

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
maps 3.3MB +112.0B 3.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar
Copy link
Member

gave this a spin and it looks good to me. Ideally in the future we can make maps emit VALUE_CLICK trigger instead of APPLY_FILTER which will make it compatible with additional actions, but this is a good start

@streamich streamich mentioned this pull request Aug 13, 2020
5 tasks
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out on Chrome, LGTM. I think we should merge this. At least it is the correct behaviour in our current architecture.

One thing that is different from other visualizations is that UI Actions popup appears right after another popup, which seems fine to me, curious what @thomasneirynck thinks.

@nreese
Copy link
Contributor

nreese commented Aug 20, 2020

Closing, replaced withhttps://github.com//pull/75598. Maps app would like to make the user select the action prior to generating the filter so there is no additional UI once the filter is generated.

@nreese nreese closed this Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants