[ML] Fix analytics list on management page. #74254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
9 tasks
|
Pinging @elastic/ml-ui (:ml) |
darnautov
reviewed
Aug 5, 2020
Comment on lines
57
to
65
| it('it should load the stack management with the ML menu item being present', async () => { | ||
| await ml.navigation.navigateToStackManagement(); | ||
| }); | ||
|
|
||
| it('it should load the jobs list page in stack management', async () => { | ||
| await ml.navigation.navigateToStackManagementJobsListPage(); | ||
| }); | ||
|
|
||
| it('it should load the analytics jobs list page in stack management', async () => { |
There was a problem hiding this comment.
nit: "it" at the beginning of the sentences seems redundant 🙂
There was a problem hiding this comment.
Of course 😅 Fixed in 0a1325e.
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Aug 6, 2020
The analytics job page in the Kibana management section didn't have the context provided by React Router and Kibana's own history object so the page crashed on load. The context is necessary to construct the correct URLs to navigate to the ML plugin itself.
This PR fixes it by wrapping the management page in <Router history={history} />. Also adds functional tests to cover navigating to the jobs list pages in stack management.
walterra
added a commit
that referenced
this pull request
Aug 10, 2020
The analytics job page in the Kibana management section didn't have the context provided by React Router and Kibana's own history object so the page crashed on load. The context is necessary to construct the correct URLs to navigate to the ML plugin itself.
This PR fixes it by wrapping the management page in <Router history={history} />. Also adds functional tests to cover navigating to the jobs list pages in stack management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #71941
Part of #72013
The analytics job page in the Kibana management section didn't have the context provided by React Router and Kibana's own history object so the page crashed on load. The context is necessary to construct the correct URLs to navigate to the ML plugin itself.
This PR fixes it by wrapping the management page in
<Router history={history} />. Also adds functional tests to cover navigating to the jobs list pages in stack management.Checklist