Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Ingest Management] main branch uses epr-snapshot. Others production (#73555) #74122

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Aug 3, 2020

Backports the following commits to 7.x:

…lastic#73555)

* Same behavior as now. Just refactored.

* main branch uses epr-snapshot. Others use prod

* Link some types vs repeating them

* replace DEFAULT_REGISTRY_URL with getRegistryUrl in Endpoint tests

* Make an Endpoint test helper name more clear

* try/catch around getKibanaBranch

* Use branch & version from package.json as fallback

* No guards b/c kibana{Branch,Version} have defaults

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/ingest_manager/common/constants/epm.ts
@jfsiii jfsiii added the backport label Aug 3, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
ingestManager 458.9KB -129.0B 459.0KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii merged commit 92ba8e2 into elastic:7.x Aug 3, 2020
@jfsiii jfsiii self-assigned this Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants