Uiactions to navigate to visualize or maps

[stratoula]

Summary

Closes #70178.

Changes the way that discover navigates to Visualize or Maps apps. We use two triggers:

• VISUALIZE_FIELD for handling the navigation to visualize editor (except geo field)
• VISUALIZE_GEO_FIELDfor handling the navigation to tilemaps or maps app

Both tilemaps and maps app register to VISUALIZE_GEO_FIELD. It is checked whether the maps app is enabled and the tilemaps is hidden or not. If it is not hidden and the maps app is enabled the user has two options to visualize a geo field. Otherwise, the Visualize button will navigate the user to the plugin that is compatible.

Update: As tilemaps are going to be deprecated we decided to not register any actions for legacy mapping visualizations.
This means that if the maps app is not enabled, the visualize button for geo fields won't appear on Discover.

Except for that, the previous functionality is the same. We had functional tests to check the navigation from discover to visualize and from discover to the maps app. I added a new one to check the navigation to tilemaps.

I have also run a flaky test server https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/741/

Checklist

• Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for cross-browser compatibility

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[timroes]

@stratoula could we then so far move that type declaraction into the plugin where it's defined?

[stratoula]

@elasticmachine merge upstream

[kertal]

Code LGTM 👍 it's much better this way, thx for this cleanup and improvement! Tested locally in Firefox, Chrome, Safari, also with a role with only Discover enabled. No regressions detected.

[kibanamachine]

💛 Build succeeded, but was flaky

• continuous-integration/kibana-ci/pull-request
• Commit: 63580ef
• Flaky suites:
  • oss-pluginFunctional

---

Test Failures

Plugin Functional Tests.test/plugin_functional/test_suites/core/route·ts.core route timeouts idle socket should timeout if servers response is too slow

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: core
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: route
[00:00:00]             └-> "before all" hook
[00:00:00]             └-: timeouts
[00:00:00]               └-> "before all" hook
[00:00:00]               └-: idle socket
[00:00:00]                 └-> "before all" hook
[00:00:00]                 └-> should timeout if payload sending has too long of an idle period
[00:00:00]                   └-> "before each" hook: global before each
[00:00:00]                   └- ✓ pass  (52ms) "core route timeouts idle socket should timeout if payload sending has too long of an idle period"
[00:00:00]                 └-> should not timeout if payload sending does not have too long of an idle period
[00:00:00]                   └-> "before each" hook: global before each
[00:00:00]                   └- ✓ pass  (223ms) "core route timeouts idle socket should not timeout if payload sending does not have too long of an idle period"
[00:00:00]                 └-> should timeout if servers response is too slow
[00:00:00]                   └-> "before each" hook: global before each
[00:00:00]                   │ info Taking screenshot "/dev/shm/workspace/parallel/3/kibana/test/functional/screenshots/failure/core route timeouts idle socket should timeout if servers response is too slow.png"
[00:00:01]                   │ info Current URL is: data:/,
[00:00:01]                   │ info Saving page source to: /dev/shm/workspace/parallel/3/kibana/test/plugin_functional/failure_debug/html/core route timeouts idle socket should timeout if servers response is too slow.html
[00:00:01]                   └- ✖ fail: core route timeouts idle socket should timeout if servers response is too slow
[00:00:01]                   │      Error: expected 'read ECONNRESET' to equal 'socket hang up'
[00:00:01]                   │       at Assertion.assert (packages/kbn-expect/expect.js:100:11)
[00:00:01]                   │       at Assertion.be.Assertion.equal (packages/kbn-expect/expect.js:227:8)
[00:00:01]                   │       at Assertion.be (packages/kbn-expect/expect.js:69:22)
[00:00:01]                   │       at result.then.err (test/plugin_functional/test_suites/core/route.ts:147:38)
[00:00:01]                   │       at process._tickCallback (internal/process/next_tick.js:68:7)
[00:00:01]                   │ 
[00:00:01]                   │ 

Stack Trace

Error: expected 'read ECONNRESET' to equal 'socket hang up'
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (packages/kbn-expect/expect.js:227:8)
    at Assertion.be (packages/kbn-expect/expect.js:69:22)
    at result.then.err (test/plugin_functional/test_suites/core/route.ts:147:38)
    at process._tickCallback (internal/process/next_tick.js:68:7)

---

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
discover	258	-7	265
maps	695	+2	693
uiActions	34	+2	32
visualize	315	+4	311
total		+1

async chunks size

id	value	diff	baseline
discover	430.7KB	-5.5KB	436.3KB
maps	3.3MB	-7.4KB	3.3MB
visualize	693.8KB	+1.0B	693.8KB
total		-12.9KB

page load bundle size

id	value	diff	baseline
discover	229.3KB	+373.0B	229.0KB
maps	296.4KB	+17.5KB	278.9KB
uiActions	218.6KB	+3.7KB	214.9KB
visualize	41.3KB	+10.3KB	31.0KB
total		+31.9KB

History

• 💚 Build #68751 succeeded c8fd6cc
• 💚 Build #68735 succeeded dfe1083
• 💚 Build #68669 succeeded 51bf61b
• 💚 Build #68660 succeeded 33777d0
• 💚 Build #68333 succeeded cdfb9fd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream