Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize graph test #73918

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Stabilize graph test #73918

merged 2 commits into from
Jul 31, 2020

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Jul 31, 2020 •
edited
Loading

Fixes #53749

Clicking the line has been very flaky in the past - to avoid this without sacrificing the test completely, this PR clicks the line element programmatically using a client side script.

Flaky runner:

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review July 31, 2020 14:06
@flash1293 flash1293 added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.0 v8.0.0 Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 requested a review from a team July 31, 2020 14:07
stratoula
stratoula approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, and the flaky runner never lies

dej611
dej611 approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flash1293 flash1293 merged commit 747e9e4 into elastic:master Jul 31, 2020
@flash1293 flash1293 deleted the fix/graph-flaky-test branch July 31, 2020 14:35
flash1293 added a commit to flash1293/kibana that referenced this pull request Jul 31, 2020
@flash1293
Stabilize graph test (elastic#73918)
621d189
@flash1293 flash1293 mentioned this pull request Jul 31, 2020
Merged
flash1293 added a commit to flash1293/kibana that referenced this pull request Jul 31, 2020
@flash1293
Stabilize graph test (elastic#73918)
6d40260
@flash1293 flash1293 mentioned this pull request Jul 31, 2020
Merged
flash1293 added a commit that referenced this pull request Jul 31, 2020
@flash1293
Stabilize graph test (#73918) (#73947)
e5a2833
flash1293 added a commit that referenced this pull request Jul 31, 2020
@flash1293
Stabilize graph test (#73918) (#73946)
a41f085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
Feature:Graph Graph application feature release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@flash1293 @kibanamachine @elasticmachine @dej611 @stratoula