Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas][tech-debt] Update Redux components to reflect new structure #73844

Merged
merged 6 commits into from
Jul 31, 2020
Merged

[Canvas][tech-debt] Update Redux components to reflect new structure #73844

merged 6 commits into from
Jul 31, 2020

Conversation

clintandrewhall
Copy link
Contributor

Summary

This PR simply moves and renames files to match the Redux component structure outlined in our CONTRIBUTING.md guidelines. Github may not understand the moves and renames, but there is no new logic in this PR.

@clintandrewhall clintandrewhall added review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v7.10.0 labels Jul 30, 2020
@clintandrewhall clintandrewhall requested a review from a team as a code owner July 30, 2020 17:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@clintandrewhall
Copy link
Contributor Author

@elasticmachine merge upstream

crob611
crob611 approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@clintandrewhall
Copy link
Contributor Author

@elasticmachine merge upstream

@clintandrewhall
Copy link
Contributor Author

@elasticmachine merge upstream

@clintandrewhall
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
canvas 1203 +14 1189

async chunks size

id value diff baseline
canvas 1.4MB +1.9KB 1.4MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit 708a30a into elastic:master Jul 31, 2020
@clintandrewhall clintandrewhall deleted the tech-debt/redux-structure branch July 31, 2020 15:39
@clintandrewhall clintandrewhall mentioned this pull request Jul 31, 2020
Merged
clintandrewhall added a commit to clintandrewhall/kibana that referenced this pull request Jul 31, 2020
@clintandrewhall @elasticmachine
[Canvas][tech-debt] Update Redux components to reflect new structure (e…
3cf1abe 
…lastic#73844)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
clintandrewhall added a commit that referenced this pull request Jul 31, 2020
@clintandrewhall @elasticmachine
[Canvas][tech-debt] Update Redux components to reflect new structure (#…
5b4e79f 
…73844) (#73967)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

Assignees
No one assigned
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clintandrewhall @elasticmachine @kibanamachine @crob611