[SIEM] Fixes a bug where invalid regular expressions within the index patterns can cause UI toaster errors #73754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aved objects for cypress hill
|
Pinging @elastic/siem (Team:SIEM) |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
yctercero
approved these changes
Jul 31, 2020
FrankHassanabad
added a commit
to FrankHassanabad/kibana
that referenced
this pull request
Jul 31, 2020
… patterns can cause UI toaster errors (elastic#73754) ## Summary elastic#49753 When you have no data you get a toaster error when we don't want a toaster error. Before with the toaster error:  After: You don't get an error toaster because I catch any regular expression errors and do not report them up to the UI. ### Checklist - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
FrankHassanabad
added a commit
that referenced
this pull request
Jul 31, 2020
… patterns can cause UI toaster errors (#73754) (#73952) ## Summary #49753 When you have no data you get a toaster error when we don't want a toaster error. Before with the toaster error:  After: You don't get an error toaster because I catch any regular expression errors and do not report them up to the UI. ### Checklist - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#49753
When you have no data you get a toaster error when we don't want a toaster error.
Before with the toaster error:
After:
You don't get an error toaster because I catch any regular expression errors and do not report them up to the UI.
Checklist