-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] fix dual axis bar overlap #73680
Conversation
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
@flash1293 or @wylieconlon could yo verify this fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally and I can now see correctly a clustered bar chart with a dual-axis.
It's just a bit weird that the title says: Stacked bar chart
but that seems to be another story: @flash1293 @wylieconlon is that a known bug?
Stacked bar chart should be stacked indeed, maybe we went too far with the unstacking. I will look into this. |
I checked on current master and it seems this case is working fine there: @nickofthyme Could you check whether this might be an elastic-charts problem? |
Wait, I misunderstood your screenshot, @markov00 - stacking just means stacking the "break down by" dimension you don't have. So while this might be a little confusing, it's still the right behavior when you got two separate axes IMHO. I'll test the PR real quick and approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested a few cases in Chrome and works as expected. Please make sure to get the same update into master (if you haven't done so already).
This fix came after a breaking change in |
Summary
Fixes #72889
Upgrades
@elastic/charts
to19.8.2
which includes only this fix (elastic/elastic-charts@v19.8.1...v19.8.2)Before
After