Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move and unify postcss config into @kbn/optimizer #73633

Merged
merged 5 commits into from
Jul 30, 2020
Merged

move and unify postcss config into @kbn/optimizer #73633

merged 5 commits into from
Jul 30, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jul 29, 2020

While moving things around as part of #73154 I found several postcss configs doing basically the same thing and thought it would be a good ideal to unify them at @kbn/optimizer/postcss.config.js

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Jul 29, 2020
@spalger spalger force-pushed the implement/unified-postcss-config branch from 24ad699 to d983138 Compare July 29, 2020 23:19
@spalger spalger marked this pull request as ready for review July 30, 2020 02:12
@spalger spalger requested review from a team as code owners July 30, 2020 02:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger
Revert "save"
30d6132 
This reverts commit 05eae6c.
@spalger spalger removed the request for review from a team July 30, 2020 02:15
clintandrewhall
clintandrewhall approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimization. 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

brianseeders
brianseeders approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@brianseeders brianseeders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit 827e91c into elastic:master Jul 30, 2020
@spalger spalger deleted the implement/unified-postcss-config branch July 30, 2020 18:16
spalger added a commit to spalger/kibana that referenced this pull request Jul 30, 2020
@spalger
move and unify postcss config into @kbn/optimizer (elastic#73633)
9858651 
Co-authored-by: spalger <spalger@users.noreply.github.com>
@spalger spalger mentioned this pull request Jul 30, 2020
Merged
spalger added a commit that referenced this pull request Jul 30, 2020
@spalger
[7.x] move and unify postcss config into @kbn/optimizer (#73633) (#…
428a021 
…73856)

Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintandrewhall clintandrewhall clintandrewhall approved these changes

@brianseeders brianseeders brianseeders approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spalger @elasticmachine @kibanamachine @clintandrewhall @brianseeders