[Security Solution][Exceptions] Use semantic version for manifest version + Scaling Tweaks #73388

madirey · 2020-07-28T01:21:18Z

Summary

Updates manifest version so that it's a semantic version (compatible with global artifacts)
Allows configuration of task interval for creating artifacts
Allows configuration of artifact validation on download
Updates validation on download route so that it consumes less memory (it was crashing on download of 5,000+ entry exception list)
Removes linux artifact generation (not needed)
Modifies UI so that endpoint exceptions are not applied to linux

Checklist

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-07-28T01:21:21Z

Pinging @elastic/endpoint-response (Team:Endpoint Response)

elasticmachine · 2020-07-28T01:21:21Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

…s-7.9

alexk307

LGTM:

Tested with 1900 items in the exception list at 50/100/200/400 agents. All configurations looked stable!

…s-7.9

madirey · 2020-07-28T18:39:03Z

@elasticmachine merge upstream

peluja1012 · 2020-07-28T19:28:55Z

.../plugins/security_solution/public/common/components/exceptions/add_exception_modal/index.tsx

@@ -233,7 +233,7 @@ export const AddExceptionModal = memo(function AddExceptionModal({
  );

  const retrieveAlertOsTypes = useCallback(() => {
-    const osDefaults = ['windows', 'macos', 'linux'];
+    const osDefaults = ['windows', 'macos'];


peluja1012

Looks good. Thanks, Madi!

madirey · 2020-07-28T19:54:14Z

@elasticmachine merge upstream

…anifest-fixes-7.9

madirey · 2020-07-29T00:36:54Z

@elasticmachine merge upstream

madirey · 2020-07-29T00:36:59Z

@elasticmachine merge upstream

elasticmachine · 2020-07-29T00:37:01Z

expected head sha didn’t match current head ref.

kibanamachine · 2020-07-29T02:43:25Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: ec86d11
Flaky suites:
- xpack-securitySolutionCypress

Test Failures

Kibana Pipeline / kibana-xpack-agent / persist the deletion of a column.persistent timeline persist the deletion of a column

Link to Jenkins

Stack Trace

AssertionError: expected 'message' to not equal 'message'
    at Context.eval (http://localhost:61141/__cypress/tests?p=cypress/integration/timeline_local_storage.spec.ts:686:40)

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	7.3MB	-8.0B	7.3MB

Saved Objects .kibana field count

id	value	diff	baseline
endpoint:user-artifact-manifest	5	+2	3

History

💔 Build #64981 failed 50f8be1
💔 Build #64965 failed b19afd5
💔 Build #64897 failed 703310d
💔 Build #64846 failed bdf68e6
💔 Build #64814 failed e1df087

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…sion + Scaling Tweaks (elastic#73388) * Manifest version is semantic version * Configurable task interval * Use task interval over scheduled when provided * Fix crash on download of large artifact * Don't need to generate linux artifacts * Configurable artifact validation * Test fixes * Test fixes * Type/test fixes * Final tweaks * Remove linux endpoint exception generation from UI * Fix paging so that we stop before 10k * Fix pagination * Fix pagination test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…sion + Scaling Tweaks (#73388) (#73610) * Manifest version is semantic version * Configurable task interval * Use task interval over scheduled when provided * Fix crash on download of large artifact * Don't need to generate linux artifacts * Configurable artifact validation * Test fixes * Test fixes * Type/test fixes * Final tweaks * Remove linux endpoint exception generation from UI * Fix paging so that we stop before 10k * Fix pagination * Fix pagination test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…sion + Scaling Tweaks (#73388) (#73609) * Manifest version is semantic version * Configurable task interval * Use task interval over scheduled when provided * Fix crash on download of large artifact * Don't need to generate linux artifacts * Configurable artifact validation * Test fixes * Test fixes * Type/test fixes * Final tweaks * Remove linux endpoint exception generation from UI * Fix paging so that we stop before 10k * Fix pagination * Fix pagination test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

madirey added 4 commits July 27, 2020 15:18

Manifest version is semantic version

c07b0e7

Configurable task interval

ac1086a

Use task interval over scheduled when provided

e96856b

Fix crash on download of large artifact

6648500

madirey added release_note:enhancement v8.0.0 Team:Endpoint Response Endpoint Response Team Feature:Endpoint Elastic Endpoint feature v7.10.0 v7.9.0 labels Jul 28, 2020

madirey requested a review from alexk307 July 28, 2020 01:21

madirey requested review from a team as code owners July 28, 2020 01:21

madirey requested a review from peluja1012 July 28, 2020 01:42

madirey added 5 commits July 28, 2020 10:01

Don't need to generate linux artifacts

9821773

Configurable artifact validation

9832204

Test fixes

0b9cb55

Merge branch 'master' of github.com:elastic/kibana into manifest-fixe…

d3ff43a

…s-7.9

Test fixes

06fa3aa

alexk307 approved these changes Jul 28, 2020

View reviewed changes

madirey added 4 commits July 28, 2020 13:13

Type/test fixes

a8732e6

Final tweaks

52f59d2

Merge branch 'master' of github.com:elastic/kibana into manifest-fixe…

722b425

…s-7.9

Remove linux endpoint exception generation from UI

e1df087

Merge branch 'master' into manifest-fixes-7.9

bdf68e6

peluja1012 reviewed Jul 28, 2020

View reviewed changes

peluja1012 approved these changes Jul 28, 2020

View reviewed changes

elasticmachine and others added 5 commits July 28, 2020 13:54

Merge branch 'master' into manifest-fixes-7.9

703310d

Fix paging so that we stop before 10k

54ff047

Merge branch 'manifest-fixes-7.9' of github.com:madirey/kibana into m…

f96a904

…anifest-fixes-7.9

Fix pagination

b19afd5

Fix pagination test

50f8be1

Merge branch 'master' into manifest-fixes-7.9

ec86d11

madirey merged commit 5a04909 into elastic:master Jul 29, 2020

madirey deleted the manifest-fixes-7.9 branch July 29, 2020 02:43

This was referenced Jul 29, 2020

[7.x] [Security Solution][Exceptions] Use semantic version for manifest version + Scaling Tweaks (#73388) #73609

Merged

[7.9] [Security Solution][Exceptions] Use semantic version for manifest version + Scaling Tweaks (#73388) #73610

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Exceptions] Use semantic version for manifest version + Scaling Tweaks #73388

[Security Solution][Exceptions] Use semantic version for manifest version + Scaling Tweaks #73388

madirey commented Jul 28, 2020 •

edited

Loading

elasticmachine commented Jul 28, 2020

elasticmachine commented Jul 28, 2020

alexk307 left a comment

madirey commented Jul 28, 2020

peluja1012 Jul 28, 2020

peluja1012 left a comment

madirey commented Jul 28, 2020

madirey commented Jul 29, 2020

madirey commented Jul 29, 2020

elasticmachine commented Jul 29, 2020

kibanamachine commented Jul 29, 2020

Stack Trace

[Security Solution][Exceptions] Use semantic version for manifest version + Scaling Tweaks #73388

[Security Solution][Exceptions] Use semantic version for manifest version + Scaling Tweaks #73388

Conversation

madirey commented Jul 28, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Jul 28, 2020

elasticmachine commented Jul 28, 2020

alexk307 left a comment

Choose a reason for hiding this comment

madirey commented Jul 28, 2020

peluja1012 Jul 28, 2020

Choose a reason for hiding this comment

peluja1012 left a comment

Choose a reason for hiding this comment

madirey commented Jul 28, 2020

madirey commented Jul 29, 2020

madirey commented Jul 29, 2020

elasticmachine commented Jul 29, 2020

kibanamachine commented Jul 29, 2020

💛 Build succeeded, but was flaky

Test Failures

Stack Trace

Build metrics

async chunks size

Saved Objects .kibana field count

History

madirey commented Jul 28, 2020 •

edited

Loading