Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Functional Tests] Unskip tsvb timeseries test #73011

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jul 23, 2020

Summary

This test was skipped during this PR #33558. I managed to reproduce the flakiness locally when I run the suite on headless mode. The error was StaleElementReferenceError: stale element reference: element is not attached to the page document. The problem was with the From Dropdown (screenshot below). The option couldn't be found so I added a retry which seems to solve the problem.

Screenshot 2020-07-23 at 3 28 31 PM

With the current solution, the flakiness is not reproducible locally, on cloud and on the flaky server (100 times) https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/650/

Checklist

@stratoula stratoula marked this pull request as ready for review July 23, 2020 13:15
@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 v7.10.0 failed-test A test failure on a tracked branch, potentially flaky-test labels Jul 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@stratoula stratoula added Feature:TSVB TSVB (Time Series Visual Builder) skipped-test Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! ❤️
It's a known issue with the stale element reference if a component was updated after it was found via selenium. This should definitely resolve the flakiness! Thanks!
LGTM

@stratoula stratoula merged commit 1ee3cdb into elastic:master Jul 23, 2020
stratoula added a commit to stratoula/kibana that referenced this pull request Jul 23, 2020
* [Functional Tests] Unskip tsvb timeseries test

* Add retry to dropdown selection when element is not found to headless mode
stratoula added a commit to stratoula/kibana that referenced this pull request Jul 23, 2020
* [Functional Tests] Unskip tsvb timeseries test

* Add retry to dropdown selection when element is not found to headless mode
stratoula added a commit that referenced this pull request Jul 23, 2020
* [Functional Tests] Unskip tsvb timeseries test

* Add retry to dropdown selection when element is not found to headless mode
stratoula added a commit that referenced this pull request Jul 27, 2020
* [Functional Tests] Unskip tsvb timeseries test

* Add retry to dropdown selection when element is not found to headless mode

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes skipped-test Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants