Fix inconsistent idQueue and ids in saved queries #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some dashboard can be saved using non-compact ids array for queries, - PR ensures that nextId() returns a valid identifier: - either one from the queue that is not used in the ids array - or one that is not used in the array - of the usual ids.length when ids is compact and idQueue is empty.
|
I've completed the CLA. Let me know if I should open a bug (although I'm not able to reproduce the steps that lead to a dashboard "corruption", with its first search starting a index 2 instead of 1). |
bpezan
pushed a commit
to bpezan/kibana
that referenced
this pull request
Dec 4, 2013
* master: Moved doc task to the end of the default task chain removed y_as_bytes, replaced with y_format Remove console.log Closes elastic#538. Closes elastic#722 Potential fix for elastic#621 More small table performance improvements Improve performance in the table. Re elastic#719 and elastic#732 Remove idQueue from filter and query services in dashboards Eliminate idQueue property from filterSrv and querySrv. Replace with binary search for smallest id. Closes elastic#730. Closes elastic#739 Skeleton API docs Doc updates Added scratchy tasks and config.js docs Bytes should not be default Fixing unsafe html binding fixed numeric terms in topN query do not auto-enable saved filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix _q helper with a method. Debugging show that there the variable was not always up to date re the idQueue