New dashboard tests using elasticdump #7298

LeeDr · 2016-05-26T21:35:16Z

This PR should replace #7272 which had some problems introduced on a shared url test.

…support/es_client.

LeeDr · 2016-05-27T16:11:16Z

jenkins, test it

LeeDr · 2016-05-27T21:25:24Z

NOTE: This PR adds dashboard tests so it probably adds a minute or two to the total test time. But it introduces elasticdump capabilities that allow us to pre-load kibana objects like default index patterns. In another PR I'll change the visualize tests to use that and that will cut some time off the tests.

jbudz · 2016-05-31T14:38:21Z

jenkins, test it

LeeDr · 2016-05-31T15:07:39Z

@jbudz I'm pretty sure that failure is not related to this PR changes. I created another issue for that type of failure; #7253

In fact, switching over to elasticdump could possibly resolve that other issue as it seems to be a kibana index corruption.

LeeDr · 2016-05-31T15:07:52Z

jenkins, test it

jbudz · 2016-05-31T15:22:23Z

test/support/pages/common.js

+    ** https://github.com/taskrabbit/elasticsearch-dump/blob/master/bin/elasticdump
+    ** and allows calling elasticdump for importing or exporting data from Elasticsearch
+    */
+    elasticdumpModule: function elasticdumpModule(myinput, myoutput, index, mytype) {


is this still needed now that there's a separate support file?

oops, no, I thought I removed that. I'll take care of it.

jbudz · 2016-05-31T15:52:33Z

Looking good. Made some comments, passing back.

jbudz · 2016-05-31T21:32:37Z

test/support/pages/common.js

@@ -11,6 +11,9 @@ export default (function () {
  var format = require('url').format;
  var util = require('util');
  var path = require('path');
+  var url = require('url');
+  var resolve = require('path').resolve;
+  var Elasticdump = require('elasticdump').elasticdump;


one more reference unused here
edit: url, resolve too

jbudz · 2016-05-31T21:35:22Z

One more comment above, LGTM after.

jbudz · 2016-05-31T21:37:05Z

Also for future reference, spoke to @LeeDr online about this - the goal is to eventually replace scenario manager with the elasticdump methods used in this PR.

LeeDr · 2016-06-01T03:27:09Z

Closes #6375

`v89.1.0`⏩`v90.0.0` The majority of changes in this PR come from: - **EuiContextMenu** being converted to Emotion (elastic/eui#7312). If your usage of `EuiContextMenu` was significantly affected, we recommend pulling down this PR and QAing it locally. - `defaultProps` being removed from some very widespread components, particularly **EuiButton**, in anticipation of React's upcoming deprecation. (elastic/eui@b7dc9b4) **NOTE**: This only affected Enzyme snapshots, and did not affect production behavior. [Commits](https://github.com/elastic/kibana/pull/170179/commits) have been broken up by component changes as well as types of changes. --- ## [`90.0.0`](https://github.com/elastic/eui/tree/v90.0.0) - Updated the `eventColor` prop on `EuiCommentEvent` to apply the color to the entire comment header. ([#7288](elastic/eui#7288)) - Updated `EuiBasicTable` and `EuiInMemoryTable` to support a new controlled selection API: `selection.selected` ([#7321](elastic/eui#7321)) **Bug fixes** - Fixed controlled `EuiFieldNumbers` not correctly updating native validity state ([#7291](elastic/eui#7291)) - Fixed `EuiListGroupItem` to pass `style` props to the wrapping `<li>` element alongside `className` and `css`. All other props will be passed to the underlying content. ([#7298](elastic/eui#7298)) - Fixed `EuiListGroupItem`'s non-transitioned transform on hover/focus ([#7298](elastic/eui#7298)) - Fixed `EuiDataGrid`s with `gridStyle.stripes` sometimes showing buggy row striping after being sorted ([#7301](elastic/eui#7301)) - Fixed `EuiDataGrid`'s `gridStyle.rowClasses` API to not conflict with `gridStyle.stripes` if dynamically updated ([#7301](elastic/eui#7301)) - Fixed `EuiDataGrid`'s `gridStyle.rowClasses` API to support multiple space-separated classes ([#7301](elastic/eui#7301)) - Fixed `EuiInputPopover` not calling `onPanelResize` callback prop ([#7305](elastic/eui#7305)) - Fixed `EuiDualRange` incorrectly positioning highlights when rendered with `showInput="inputWithPopover"` ([#7305](elastic/eui#7305)) - Fixed `EuiTabs` incorrectly wrapping text when it should instead either scroll or truncate ([#7309](elastic/eui#7309)) - `EuiContextMenu` now renders text colors correctly when used within an `EuiBottomBar` ([#7312](elastic/eui#7312)) - Fixed the width of `EuiSuperDatePicker`'s Absolute date picker ([#7313](elastic/eui#7313)) - Fixed `EuiDataGrid` cells visually cutting off overflowing content a little too quickly ([#7320](elastic/eui#7320)) **Deprecations** - Deprecated `EuiBasicTable` and `EuiInMemoryTable`'s ref `setSelection` API. Use the new `selection.selected` API instead. ([#7321](elastic/eui#7321)) **Breaking changes** - Removed `EuiPageTemplate_Deprecated`, `EuiPageSideBar_Deprecated`, and `EuiPageContent*_Deprecated` ([#7265](elastic/eui#7265)) - Removed the `ghost` color option from `EuiButton`, `EuiButtonEmpty`, and `EuiButtonIcon`. Use an `<EuiThemeProvider colorMode="dark">` wrapper and `color="text"` instead. ([#7296](elastic/eui#7296)) **Dependency updates** - Updated `refractor` to v3.6.0 ([#7127](elastic/eui#7127)) - Updated `rehype-raw` to v5.1.0 ([#7127](elastic/eui#7127)) - Updated `vfile` to v4.2.1 ([#7127](elastic/eui#7127)) **Accessibility** - `EuiContextMenu` now correctly respects reduced motion preferences ([#7312](elastic/eui#7312)) - `EuiAccordion`s no longer attempt to focus child content when the accordion is externally opened via `forceState`, but will continue to focus expanded content when users click the toggle button. ([#7314](elastic/eui#7314)) **CSS-in-JS conversions** - Converted `EuiContextMenu`, `EuiContextMenuPanel`, and `EuiContextMenuItem` to Emotion; Removed `$euiContextMenuWidth` ([#7312](elastic/eui#7312))

New dashboard tests using elasticdump

988be91

LeeDr added the test label May 26, 2016

LeeDr mentioned this pull request May 26, 2016

[WIP] Dashboard tests using elasticdump to load data #7272

Closed

LeeDr added 3 commits May 27, 2016 08:20

Add missing Dashboard test files.

1333cbe

Remove some unused vars.

53ede1a

Move updateConfigDoc method out of scenario_manager and into its own …

ac4a0ed

…support/es_client.

Moved elasticdump methods from common to support/elastic_dump.js

4ebe29e

LeeDr changed the title ~~[WIP] New dashboard tests using elasticdump~~ New dashboard tests using elasticdump May 27, 2016

LeeDr added the review label May 27, 2016

LeeDr assigned jbudz May 27, 2016

Correct a dashboard test sub-suite name.

f28fc89

jbudz reviewed May 31, 2016
View reviewed changes

jbudz assigned LeeDr May 31, 2016

LeeDr added 2 commits May 31, 2016 12:15

Some cleanup from review comments.

411bacd

Remove unused self.

1566cc3

jbudz reviewed May 31, 2016
View reviewed changes

Removed un-used requires.

9fe89d9

LeeDr merged commit b50451f into elastic:master May 31, 2016

LeeDr mentioned this pull request Jun 1, 2016

Automate functional tests for Dashboards #6375

Closed

LeeDr mentioned this pull request Jun 13, 2016

Test failures caused by setting UTC in timezone #7218

Closed

LeeDr deleted the dashboardTests branch May 23, 2017 13:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New dashboard tests using elasticdump #7298

New dashboard tests using elasticdump #7298

LeeDr commented May 26, 2016

LeeDr commented May 27, 2016

LeeDr commented May 27, 2016

jbudz commented May 31, 2016

LeeDr commented May 31, 2016

LeeDr commented May 31, 2016

jbudz May 31, 2016

LeeDr May 31, 2016

jbudz commented May 31, 2016

jbudz May 31, 2016 •

edited

Loading

jbudz commented May 31, 2016

jbudz commented May 31, 2016

LeeDr commented Jun 1, 2016

New dashboard tests using elasticdump #7298

New dashboard tests using elasticdump #7298

Conversation

LeeDr commented May 26, 2016

LeeDr commented May 27, 2016

LeeDr commented May 27, 2016

jbudz commented May 31, 2016

LeeDr commented May 31, 2016

LeeDr commented May 31, 2016

jbudz May 31, 2016

Choose a reason for hiding this comment

LeeDr May 31, 2016

Choose a reason for hiding this comment

jbudz commented May 31, 2016

jbudz May 31, 2016 • edited Loading

Choose a reason for hiding this comment

jbudz commented May 31, 2016

jbudz commented May 31, 2016

LeeDr commented Jun 1, 2016

jbudz May 31, 2016 •

edited

Loading