[Resolver] Quick perf fix #72728
Closed
[Resolver] Quick perf fix #72728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 21, 2020 13:23
also renames 'isProcessOrigin' params in resolver theme to be 'isProcessTrigger'. NB: this does not use the trigger node styling
UI state changes: * rename `activeDescendantId` to `ariaActiveDescendant`. it has the nodeID (aka entity_id) of the aria active descendant * rename `processEntityIdOfSelectedDescendant` to `selectedNode`. it has the nodeID (aka entity_id) of the selected node * aria html attributes were wrong (this also effected styling.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Performance tuning the Resolver UI. I based this on #72382 because its going to go in soon and I don't want to rebase against it and get conflicts.
Some images to help interpret the baseline test results:
These are animations captured during a second run (without performance profile being recorded) of
baseline_test_3These animations happen regularly and slow FPS a lot.
Animations recorded during
baseline_test_5. these don't have details because they are from the performance profile. But you get the idea. Too many animations:Checklist
Delete any items that are not applicable to this PR.
For maintainers