Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Fix No Data in Inventory alerts/Snapshot API #72513

Merged
merged 4 commits into from
Jul 29, 2020
Merged

[Metrics UI] Fix No Data in Inventory alerts/Snapshot API #72513

merged 4 commits into from
Jul 29, 2020

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Jul 20, 2020

Summary

Fixes #71874

  • Adds proper No Data reporting to Snapshot API, plus a test
  • Fixes the Inventory alert so that it reports No Data when there are no nodes returned

Checklist

Delete any items that are not applicable to this PR.

@Zacqary Zacqary added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.0 labels Jul 20, 2020
@Zacqary Zacqary requested a review from a team as a code owner July 20, 2020 19:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary
Copy link
Contributor Author

Zacqary commented Jul 23, 2020

@elasticmachine merge upstream

@Zacqary
Copy link
Contributor Author

Zacqary commented Jul 28, 2020

@elasticmachine merge upstream

@Zacqary Zacqary added this to the Logs UI 7.9 milestone Jul 28, 2020
@Zacqary Zacqary modified the milestones: Logs UI 7.9, Metrics UI 7.9 Jul 28, 2020
@Zacqary
Copy link
Contributor Author

Zacqary commented Jul 28, 2020

@elasticmachine merge upstream

@phillipb phillipb self-requested a review July 28, 2020 21:05
simianhacker
simianhacker approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary merged commit e202a83 into elastic:master Jul 29, 2020
@Zacqary Zacqary deleted the 71874-nodata-inventory-fix branch July 29, 2020 16:07
Zacqary added a commit to Zacqary/kibana that referenced this pull request Jul 29, 2020
@Zacqary @elasticmachine
[Metrics UI] Fix No Data in Inventory alerts/Snapshot API (elastic#72513
e9e088c 
)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced Jul 29, 2020
Merged
Merged
Zacqary added a commit to Zacqary/kibana that referenced this pull request Jul 29, 2020
@Zacqary @elasticmachine
[Metrics UI] Fix No Data in Inventory alerts/Snapshot API (elastic#72513
9ed9951 
)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Zacqary added a commit that referenced this pull request Jul 29, 2020
@Zacqary @elasticmachine
[7.9] [Metrics UI] Fix No Data in Inventory alerts/Snapshot API (#72513…
0e8c71e 
…) (#73701)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 30, 2020
@gmmorris
Merge branch 'actions/webhook-remove-header' of github.com:gmmorris/k…
031e0d8 
…ibana into actions/webhook-remove-header

* 'actions/webhook-remove-header' of github.com:gmmorris/kibana: (86 commits)
  [maps] rename GisMap to MapContainer and convert to TS (elastic#73690)
  [APM] docs: remove watcher documentation  (elastic#73485)
  [Maps] fix fit to data for Point to Point layer (elastic#73563)
  [Metrics UI] Fix No Data in Inventory alerts/Snapshot API (elastic#72513)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  ...
Zacqary added a commit that referenced this pull request Jul 31, 2020
@Zacqary @elasticmachine
[7.x] [Metrics UI] Fix No Data in Inventory alerts/Snapshot API (#72513…
455835f 
…) (#73700)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simianhacker simianhacker simianhacker approved these changes

@phillipb phillipb Awaiting requested review from phillipb

Assignees
No one assigned
Labels
Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
Metrics UI 7.9
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Alert for no data doesn't work for inventory alert
4 participants
@Zacqary @elasticmachine @kibanamachine @simianhacker