Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Webhook connector doesn't retain added HTTP header settings #71924

Conversation

YulNaumenko
Copy link
Contributor

Resolve #70907

@YulNaumenko YulNaumenko added bug Fixes for quality problems that affect the customer experience release_note:fix Feature:Alerting v8.0.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.9.0 labels Jul 15, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner July 15, 2020 18:46
@YulNaumenko YulNaumenko self-assigned this Jul 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM and the previously added header now shows up when edited again

However, I played around a bit more - added a second header, saved, and it gets redisplayed as well. Delete one of those headers, saved, and when edited again, it does not show (as expected). However, I checked with kbn-action ls, and it's actually still there. When I hard refresh the page, it will then get displayed again.

I'm guessing we want to fix that in this issue, hence a "request changes" response, but if we want to fix this in a separate issue, happy to change to "approve" since I think the original issue did get fixed.

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wops - somehow managed to duplicate my comment ^^^ - these review comments are weird in that it's hard to get a link to them and you can't delete them!

@YulNaumenko
Copy link
Contributor Author

wops - somehow managed to duplicate my comment ^^^ - these review comments are weird in that it's hard to get a link to them and you can't delete them!

@pmuellr this problem is something very different then we have in the description of the current issue - deleting of headers record doesn't work on the savedObject level. It was deleted in the update request, but some sort of caching happening in saveObjectClient find. If we update with the new header record, then it works as expected. I've created a separate issue - #71995

@pmuellr
Copy link
Member

pmuellr commented Jul 16, 2020

this problem is something very different then we have in the description of the current issue (deleting headers doesn't work)

Ya, figured - it seemed quite a bit different. I'll change my review to approve, thx!

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a previous review, everything looked but, but found another issue, wasn't sure if was related. Wasn't, so a new issue got opened up to fix it: #71995

So, now approving, since everything looked good besides that.

…bhook-connector-headers

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/fleet/unenroll_agent·ts.apis Fleet Endpoints fleet_unenroll_agent allow to unenroll using a list of ids

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 8 times on tracked branches: https://github.com/elastic/kibana/issues/64696

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook
[00:07:37]           └-: Fleet Endpoints
[00:07:37]             └-> "before all" hook
[00:07:41]             └-: fleet_unenroll_agent
[00:07:41]               └-> "before all" hook
[00:07:41]               └-> "before all" hook
[00:07:41]                 │ info [fleet/agents] Loading "mappings.json"
[00:07:41]                 │ info [fleet/agents] Loading "data.json"
[00:07:41]                 │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] [.kibana_2/5P3UE817T5SeefJaZ2UNvQ] deleting index
[00:07:41]                 │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] [.kibana_1/rZ72WwCQR56B7qIficeXdQ] deleting index
[00:07:41]                 │ info [fleet/agents] Deleted existing index [".kibana_2",".kibana_1"]
[00:07:41]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] [.kibana_1] creating index, cause [api], templates [], shards [1]/[0]
[00:07:41]                 │ info [fleet/agents] Created index ".kibana_1"
[00:07:41]                 │ debg [fleet/agents] ".kibana_1" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:07:41]                 │ info [fleet/agents] Indexed 12 docs into ".kibana"
[00:07:41]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] [.kibana_1/TxTursk9T4GP9i61OE3l-g] update_mapping [_doc]
[00:07:41]                 │ debg Migrating saved objects
[00:07:41]                 │ proc [kibana]   log   [18:57:49.344] [info][savedobjects-service] Detected mapping change in "dynamic"
[00:07:41]                 │ proc [kibana]   log   [18:57:49.347] [info][savedobjects-service] Creating index .kibana_2.
[00:07:41]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1]
[00:07:41]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] updating number_of_replicas to [0] for indices [.kibana_2]
[00:07:41]                 │ proc [kibana]   log   [18:57:49.432] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:07:41]                 │ proc [kibana]   log   [18:57:49.446] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:07:41]                 │ proc [kibana]   log   [18:57:49.506] [info][savedobjects-service] Finished in 161ms.
[00:07:41]               └-> "before all" hook
[00:07:41]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] [.kibana_2/ud4_cpOVTFiZ3wU6OzpCSw] update_mapping [_doc]
[00:07:41]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] [metrics-index_pattern_placeholder] creating index, cause [api], templates [], shards [1]/[1]
[00:07:41]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] [events-index_pattern_placeholder] creating index, cause [api], templates [], shards [1]/[1]
[00:07:41]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] [logs-index_pattern_placeholder] creating index, cause [api], templates [], shards [1]/[1]
[00:07:43]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] [.kibana_2/ud4_cpOVTFiZ3wU6OzpCSw] update_mapping [_doc]
[00:07:43]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] [.kibana_2/ud4_cpOVTFiZ3wU6OzpCSw] update_mapping [_doc]
[00:07:44]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] [.kibana_2/ud4_cpOVTFiZ3wU6OzpCSw] update_mapping [_doc]
[00:07:45]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] [.kibana_2/ud4_cpOVTFiZ3wU6OzpCSw] update_mapping [_doc]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding component template [metrics-endpoint.metadata-mappings]
[00:07:45]                 │ proc [kibana]  error  [18:57:52.805] [warning][process] UnhandledPromiseRejectionWarning: Error: [epm-packages:system]: version conflict, required seqNo [94], primary term [1]. current document has seqNo [102] and primary term [1]: [version_conflict_engine_exception] [epm-packages:system]: version conflict, required seqNo [94], primary term [1]. current document has seqNo [102] and primary term [1], with { index_uuid="ud4_cpOVTFiZ3wU6OzpCSw" & shard="0" & index=".kibana_2" }
[00:07:45]                 │ proc [kibana]     at respond (/dev/shm/workspace/install/kibana-7/node_modules/elasticsearch/src/lib/transport.js:349:15)
[00:07:45]                 │ proc [kibana]     at checkRespForFailure (/dev/shm/workspace/install/kibana-7/node_modules/elasticsearch/src/lib/transport.js:306:7)
[00:07:45]                 │ proc [kibana]     at HttpConnector.<anonymous> (/dev/shm/workspace/install/kibana-7/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
[00:07:45]                 │ proc [kibana]     at IncomingMessage.wrapper (/dev/shm/workspace/install/kibana-7/node_modules/lodash/lodash.js:4929:19)
[00:07:45]                 │ proc [kibana]     at IncomingMessage.emit (events.js:203:15)
[00:07:45]                 │ proc [kibana]     at endReadableNT (_stream_readable.js:1145:12)
[00:07:45]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:63:19)
[00:07:45]                 │ proc [kibana]     at emitWarning (internal/process/promises.js:97:15)
[00:07:45]                 │ proc [kibana]     at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
[00:07:45]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:69:34)
[00:07:45]                 │ proc [kibana]  error  [18:57:52.807] [warning][process] Error: [epm-packages:system]: version conflict, required seqNo [94], primary term [1]. current document has seqNo [102] and primary term [1]: [version_conflict_engine_exception] [epm-packages:system]: version conflict, required seqNo [94], primary term [1]. current document has seqNo [102] and primary term [1], with { index_uuid="ud4_cpOVTFiZ3wU6OzpCSw" & shard="0" & index=".kibana_2" }
[00:07:45]                 │ proc [kibana]     at respond (/dev/shm/workspace/install/kibana-7/node_modules/elasticsearch/src/lib/transport.js:349:15)
[00:07:45]                 │ proc [kibana]     at checkRespForFailure (/dev/shm/workspace/install/kibana-7/node_modules/elasticsearch/src/lib/transport.js:306:7)
[00:07:45]                 │ proc [kibana]     at HttpConnector.<anonymous> (/dev/shm/workspace/install/kibana-7/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
[00:07:45]                 │ proc [kibana]     at IncomingMessage.wrapper (/dev/shm/workspace/install/kibana-7/node_modules/lodash/lodash.js:4929:19)
[00:07:45]                 │ proc [kibana]     at IncomingMessage.emit (events.js:203:15)
[00:07:45]                 │ proc [kibana]     at endReadableNT (_stream_readable.js:1145:12)
[00:07:45]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:63:19)
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding component template [logs-endpoint.alerts-mappings]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding component template [logs-endpoint.events.library-mappings]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding component template [metrics-endpoint.policy-mappings]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding component template [logs-endpoint.events.process-mappings]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding component template [logs-endpoint.events.file-mappings]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding component template [logs-endpoint.events.network-mappings]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding component template [logs-endpoint.events.security-mappings]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding component template [metrics-endpoint.telemetry-mappings]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding component template [logs-endpoint.events.registry-mappings]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-endpoint.metadata] for index patterns [metrics-endpoint.metadata-*]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [logs-endpoint.alerts] for index patterns [logs-endpoint.alerts-*]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [logs-endpoint.events.library] for index patterns [logs-endpoint.events.library-*]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-endpoint.policy] for index patterns [metrics-endpoint.policy-*]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [logs-endpoint.events.process] for index patterns [logs-endpoint.events.process-*]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [logs-endpoint.events.file] for index patterns [logs-endpoint.events.file-*]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [logs-endpoint.events.network] for index patterns [logs-endpoint.events.network-*]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [logs-endpoint.events.security] for index patterns [logs-endpoint.events.security-*]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-endpoint.telemetry] for index patterns [metrics-endpoint.telemetry-*]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [logs-endpoint.events.registry] for index patterns [logs-endpoint.events.registry-*]
[00:07:45]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.diskio] for index patterns [metrics-system.diskio-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [logs-system.auth] for index patterns [logs-system.auth-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.core] for index patterns [metrics-system.core-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.cpu] for index patterns [metrics-system.cpu-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.filesystem] for index patterns [metrics-system.filesystem-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.entropy] for index patterns [metrics-system.entropy-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.fsstat] for index patterns [metrics-system.fsstat-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.network] for index patterns [metrics-system.network-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.network_summary] for index patterns [metrics-system.network_summary-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.process_summary] for index patterns [metrics-system.process_summary-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.process] for index patterns [metrics-system.process-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.load] for index patterns [metrics-system.load-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.memory] for index patterns [metrics-system.memory-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.raid] for index patterns [metrics-system.raid-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.service] for index patterns [metrics-system.service-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.socket] for index patterns [metrics-system.socket-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.socket_summary] for index patterns [metrics-system.socket_summary-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.uptime] for index patterns [metrics-system.uptime-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [logs-system.syslog] for index patterns [logs-system.syslog-*]
[00:07:46]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-centos-tests-xl-1594922239853141365] adding index template [metrics-system.users] for index patterns [metrics-system.users-*]
[00:07:47]                 │ proc [kibana]  error  [18:57:54.632] [warning][process] PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 111)
[00:07:47]                 │ proc [kibana]     at handledRejection (internal/process/promises.js:71:23)
[00:07:47]                 │ proc [kibana]     at all (internal/process/promises.js:36:14)
[00:07:47]                 │ proc [kibana]     at Promise.then (<anonymous>)
[00:07:47]                 │ proc [kibana]     at Function.all (<anonymous>)
[00:07:47]                 │ proc [kibana]     at installPackage (/dev/shm/workspace/install/kibana-7/x-pack/plugins/ingest_manager/server/services/epm/packages/install.js:184:49)
[00:07:47]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:68:7)
[00:07:47]                 │ proc [kibana]  error  [18:57:54.695] [warning][process] UnhandledPromiseRejectionWarning: Error: [epm-packages:system]: version conflict, required seqNo [94], primary term [1]. current document has seqNo [102] and primary term [1]: [version_conflict_engine_exception] [epm-packages:system]: version conflict, required seqNo [94], primary term [1]. current document has seqNo [102] and primary term [1], with { index_uuid="ud4_cpOVTFiZ3wU6OzpCSw" & shard="0" & index=".kibana_2" }
[00:07:47]                 │ proc [kibana]     at respond (/dev/shm/workspace/install/kibana-7/node_modules/elasticsearch/src/lib/transport.js:349:15)
[00:07:47]                 │ proc [kibana]     at checkRespForFailure (/dev/shm/workspace/install/kibana-7/node_modules/elasticsearch/src/lib/transport.js:306:7)
[00:07:47]                 │ proc [kibana]     at HttpConnector.<anonymous> (/dev/shm/workspace/install/kibana-7/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
[00:07:47]                 │ proc [kibana]     at IncomingMessage.wrapper (/dev/shm/workspace/install/kibana-7/node_modules/lodash/lodash.js:4929:19)
[00:07:47]                 │ proc [kibana]     at IncomingMessage.emit (events.js:203:15)
[00:07:47]                 │ proc [kibana]     at endReadableNT (_stream_readable.js:1145:12)
[00:07:47]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:63:19)
[00:07:47]                 │ proc [kibana]     at emitWarning (internal/process/promises.js:97:15)
[00:07:47]                 │ proc [kibana]     at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
[00:07:47]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:69:34)
[00:07:47]                 │ proc [kibana]  error  [18:57:54.696] [warning][process] Error: [epm-packages:system]: version conflict, required seqNo [94], primary term [1]. current document has seqNo [102] and primary term [1]: [version_conflict_engine_exception] [epm-packages:system]: version conflict, required seqNo [94], primary term [1]. current document has seqNo [102] and primary term [1], with { index_uuid="ud4_cpOVTFiZ3wU6OzpCSw" & shard="0" & index=".kibana_2" }
[00:07:47]                 │ proc [kibana]     at respond (/dev/shm/workspace/install/kibana-7/node_modules/elasticsearch/src/lib/transport.js:349:15)
[00:07:47]                 │ proc [kibana]     at checkRespForFailure (/dev/shm/workspace/install/kibana-7/node_modules/elasticsearch/src/lib/transport.js:306:7)
[00:07:47]                 │ proc [kibana]     at HttpConnector.<anonymous> (/dev/shm/workspace/install/kibana-7/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
[00:07:47]                 │ proc [kibana]     at IncomingMessage.wrapper (/dev/shm/workspace/install/kibana-7/node_modules/lodash/lodash.js:4929:19)
[00:07:47]                 │ proc [kibana]     at IncomingMessage.emit (events.js:203:15)
[00:07:47]                 │ proc [kibana]     at endReadableNT (_stream_readable.js:1145:12)
[00:07:47]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:63:19)
[00:07:47]                 │ proc [kibana]  error  [18:57:54.718] [warning][process] PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 113)
[00:07:47]                 │ proc [kibana]     at handledRejection (internal/process/promises.js:71:23)
[00:07:47]                 │ proc [kibana]     at promiseRejectHandler (internal/process/promises.js:36:14)
[00:07:47]                 │ proc [kibana]     at Promise.then (<anonymous>)
[00:07:47]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:68:7)
[00:07:47]               └-> allow to unenroll using a list of ids
[00:07:47]                 └-> "before each" hook: global before each
[00:07:47]                 └-> "before each" hook
[00:07:47]                   │ proc [kibana]  error  [18:57:54.701]  Error: Internal Server Error
[00:07:47]                   │ proc [kibana]     at HapiResponseAdapter.toError (/dev/shm/workspace/install/kibana-7/src/core/server/http/router/response_adapter.js:132:19)
[00:07:47]                   │ proc [kibana]     at HapiResponseAdapter.toHapiResponse (/dev/shm/workspace/install/kibana-7/src/core/server/http/router/response_adapter.js:86:19)
[00:07:47]                   │ proc [kibana]     at HapiResponseAdapter.handle (/dev/shm/workspace/install/kibana-7/src/core/server/http/router/response_adapter.js:81:17)
[00:07:47]                   │ proc [kibana]     at Router.handle (/dev/shm/workspace/install/kibana-7/src/core/server/http/router/router.js:162:34)
[00:07:47]                   │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:68:7)
[00:07:48]                 └- ✖ fail: apis Fleet Endpoints fleet_unenroll_agent allow to unenroll using a list of ids
[00:07:48]                 │      Error: expected 200 "OK", got 500 "Internal Server Error"
[00:07:48]                 │       at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
[00:07:48]                 │       at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
[00:07:48]                 │       at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
[00:07:48]                 │       at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
[00:07:48]                 │       at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
[00:07:48]                 │       at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/index.js:718:3)
[00:07:48]                 │       at parser (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/index.js:906:18)
[00:07:48]                 │       at IncomingMessage.res.on (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/parsers/json.js:19:7)
[00:07:48]                 │       at endReadableNT (_stream_readable.js:1145:12)
[00:07:48]                 │       at process._tickCallback (internal/process/next_tick.js:63:19)
[00:07:48]                 │ 
[00:07:48]                 │ 

Stack Trace

Error: expected 200 "OK", got 500 "Internal Server Error"
    at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
    at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
    at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
    at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
    at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/index.js:718:3)
    at parser (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/index.js:906:18)
    at IncomingMessage.res.on (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/parsers/json.js:19:7)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

Build metrics

async chunks size

id value diff baseline
triggers_actions_ui 703.7KB +29.0B 703.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko merged commit 9da8b76 into elastic:master Jul 16, 2020
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Jul 16, 2020
…astic#71924)

* Fixed Webhook connector doesn't retain added HTTP header settings

* fixed method
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Jul 16, 2020
…astic#71924)

* Fixed Webhook connector doesn't retain added HTTP header settings

* fixed method
YulNaumenko added a commit that referenced this pull request Jul 16, 2020
…1924) (#72162)

* Fixed Webhook connector doesn't retain added HTTP header settings

* fixed method
YulNaumenko added a commit that referenced this pull request Jul 16, 2020
…1924) (#72163)

* Fixed Webhook connector doesn't retain added HTTP header settings

* fixed method
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
* master: (214 commits)
  replacing hard coded links for ela.st (elastic#72240)
  skip flaky suite (elastic#60865)
  chore(NA): teardown dynamic dll plugin (elastic#72096)
  Register navLink actions for declared applications (elastic#72109)
  Fix value for process.hash.sha256 draggable (elastic#72142)
  Call setupIngest before fleet_install tests (elastic#72214)
  [Security Solution][Detections] Better toast errors (elastic#72205)
  skip flaky suite (elastic#64696)
  [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137)
  [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990)
  [baseline/capture] use high-memory nodes with ramDisks (elastic#71894)
  skip flaky suite (elastic#77207)
  [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946)
  using test_user with minimum privs (elastic#71988)
  Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924)
  [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921)
  [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125)
  [Visualizations] Pass 'aggs' parameter to custom request handlers (elastic#71423)
  [Monitoring] Out of the box alert tweaks (elastic#71942)
  [ML] Fix datafeed start time is incorrect when the job has trailing empty buckets (elastic#71976)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
* master: (55 commits)
  updates 'External alerts' tab text (elastic#72237)
  [Security Solution][Case] Fix connector's dropdown with conflicting requests (elastic#72037)
  replacing hard coded links for ela.st (elastic#72240)
  skip flaky suite (elastic#60865)
  chore(NA): teardown dynamic dll plugin (elastic#72096)
  Register navLink actions for declared applications (elastic#72109)
  Fix value for process.hash.sha256 draggable (elastic#72142)
  Call setupIngest before fleet_install tests (elastic#72214)
  [Security Solution][Detections] Better toast errors (elastic#72205)
  skip flaky suite (elastic#64696)
  [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137)
  [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990)
  [baseline/capture] use high-memory nodes with ramDisks (elastic#71894)
  skip flaky suite (elastic#77207)
  [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946)
  using test_user with minimum privs (elastic#71988)
  Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924)
  [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921)
  [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125)
  [Visualizations] Pass 'aggs' parameter to custom request handlers (elastic#71423)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
…feature-privileges

* alerting/consumer-based-rbac: (56 commits)
  take into account which features available in the active space
  updates 'External alerts' tab text (elastic#72237)
  [Security Solution][Case] Fix connector's dropdown with conflicting requests (elastic#72037)
  replacing hard coded links for ela.st (elastic#72240)
  skip flaky suite (elastic#60865)
  chore(NA): teardown dynamic dll plugin (elastic#72096)
  Register navLink actions for declared applications (elastic#72109)
  Fix value for process.hash.sha256 draggable (elastic#72142)
  Call setupIngest before fleet_install tests (elastic#72214)
  [Security Solution][Detections] Better toast errors (elastic#72205)
  skip flaky suite (elastic#64696)
  [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137)
  [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990)
  [baseline/capture] use high-memory nodes with ramDisks (elastic#71894)
  skip flaky suite (elastic#77207)
  [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946)
  using test_user with minimum privs (elastic#71988)
  Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924)
  [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921)
  [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook Alert doesn't retain added HTTP header settings
4 participants